Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e88d098e5083329c5afdd6bf66f69c448b9f9be2
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: a416692e93054ad66af315f41647d36611e9ad03
Choose a head ref
  • 5 commits
  • 6 files changed
  • 1 contributor

Commits on May 23, 2020

  1. repl: remove deprecated .rli 

    The .rli property is just a reference to the active REPL instance
and it was deprecated for a long time.

To improve maintainability of the REPL this feature is removed.

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

PR-URL: #33286
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @BridgeAR
    BridgeAR committed May 23, 2020
    Configuration menu
    Copy the full SHA
    3752430 View commit details
    Browse the repository at this point in the history

  2. repl: remove deprecated bufferedCommand property 

    This property is deprecated since Node.js v9.0.0 and to improve
maintainability of the REPL it is now removed.

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

PR-URL: #33286
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @BridgeAR
    BridgeAR committed May 23, 2020
    Configuration menu
    Copy the full SHA
    4ace010 View commit details
    Browse the repository at this point in the history

  3. repl: remove deprecated repl.parseREPLKeyword() function 

    This removes the deprecated REPLServer.parseREPLKeyword function. It
is deprecated for a long time and should not provide any benefit to
users. To improve the maintainability of the REPL module, it's now
removed.

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

PR-URL: #33286
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @BridgeAR
    BridgeAR committed May 23, 2020
    Configuration menu
    Copy the full SHA
    a1bcad8 View commit details
    Browse the repository at this point in the history

  4. repl: remove deprecated repl.turnOffEditorMode() function 

    This function is deprecated for multiple years and provides very
little benefit to users. Thus, it's removed to improve the
maintainability of the REPL module.

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

PR-URL: #33286
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @BridgeAR
    BridgeAR committed May 23, 2020
    Configuration menu
    Copy the full SHA
    f217b2d View commit details
    Browse the repository at this point in the history

  5. repl: remove deprecated repl.memory function 

    This removes the memory function. It is deprecated for a long time
while not being really helpful being exposed. Thus, it is removed
to improve maintainability of the REPL module.

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

PR-URL: #33286
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @BridgeAR
    BridgeAR committed May 23, 2020
    Configuration menu
    Copy the full SHA
    a416692 View commit details
    Browse the repository at this point in the history
Loading