Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e767aa1a2e5e9b7445dc0974ab21d33941f100ff
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: c07c73ced78a8ad9f5aab786072fba04f5aa625c
Choose a head ref
  • 2 commits
  • 1 file changed
  • 1 contributor

Commits on Apr 23, 2018

  1. src: prefer false instead of bool zero 

    This commit updates node_crypto.cc VerifySpkac function to use false
instead of 0 for its return bool value i.

PR-URL: #20218
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @danbev @addaleax
    danbev authored and addaleax committed Apr 23, 2018
    Configuration menu
    Copy the full SHA
    e3b0fb0 View commit details
    Browse the repository at this point in the history

  2. src: rename return var in VerifySpkac functions 

    This commit renames the verification result variable, that is currently
named i, to verify_result.

PR-URL: #20218
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @danbev @addaleax
    danbev authored and addaleax committed Apr 23, 2018
    Configuration menu
    Copy the full SHA
    c07c73c View commit details
    Browse the repository at this point in the history
Loading