Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e11388b245d9822fcaf2209baaa9e1958d102d2d
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 902c71a9d09bce6b1da4258d1775375f6539bbec
Choose a head ref
  • 3 commits
  • 7 files changed
  • 1 contributor

Commits on Feb 11, 2019

  1. worker: pre-allocate thread id 

    Allocate a thread id before actually creating the Environment instance.

PR-URL: #26011
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    @addaleax
    addaleax committed Feb 11, 2019
    Configuration menu
    Copy the full SHA
    58ba8bf View commit details
    Browse the repository at this point in the history

  2. worker: set up child Isolate inside Worker thread 

    Refs: #24016

PR-URL: #26011
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    @addaleax
    addaleax committed Feb 11, 2019
    Configuration menu
    Copy the full SHA
    5bc6e49 View commit details
    Browse the repository at this point in the history

  3. test: add Worker + --prof regression test 

    Fixes: #24016

PR-URL: #26011
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    @addaleax
    addaleax committed Feb 11, 2019
    Configuration menu
    Copy the full SHA
    902c71a View commit details
    Browse the repository at this point in the history
Loading