Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e029bc94e6404ac79cf304abbbd43325d407f668
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: f617a732f86289f39e4f2ce41564b0f35b00a9cf
Choose a head ref
  • 3 commits
  • 4 files changed
  • 1 contributor

Commits on Mar 8, 2019

  1. process: call prepareMainThreadExecution in node inspect 

    Since we should treat the node-inspect as third-party
user code.

PR-URL: #26466
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    @joyeecheung
    joyeecheung committed Mar 8, 2019
    Configuration menu
    Copy the full SHA
    f9b76c3 View commit details
    Browse the repository at this point in the history

  2. process: set up process warning handler in pre-execution 

    Since it depends on environment variables.

PR-URL: #26466
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    @joyeecheung
    joyeecheung committed Mar 8, 2019
    Configuration menu
    Copy the full SHA
    d7543a7 View commit details
    Browse the repository at this point in the history

  3. process: handle process.env.NODE_V8_COVERAGE in pre-execution 

    Since this depends on environment variable, and the worker threads
do not need to persist the variable value because they cannot
switch cwd.

PR-URL: #26466
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    @joyeecheung
    joyeecheung committed Mar 8, 2019
    Configuration menu
    Copy the full SHA
    f617a73 View commit details
    Browse the repository at this point in the history
Loading