Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: d63bcdd9cd81b10b6158f40d44bf6f37e5f54385
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 303e2fdc598cbc82af401f12f3cc9169ed31598b
Choose a head ref
  • 2 commits
  • 10 files changed
  • 1 contributor

Commits on Feb 13, 2020

  1. src: add ExclusiveAccess class 

    Similar to Rust's `std::sync::Mutex` in that it requires one to unwrap
the object before accessing it, acquiring the mutex in the process.

PR-URL: #31717
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
    @bnoordhuis @addaleax
    bnoordhuis authored and addaleax committed Feb 13, 2020
    Configuration menu
    Copy the full SHA
    b32fa7b View commit details
    Browse the repository at this point in the history

  2. src: wrap HostPort in ExclusiveAccess 

    I found it exceedingly hard to figure out if there is a race condition
where one thread reads the inspector agent's HostPort's properties while
another modifies them concurrently.

I think the answer is "no, there isn't" but with this commit use sites
are forced to unwrap the object (and acquire the mutex in the process),
making it a great deal easier to reason about correctness.

PR-URL: #31717
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
    @bnoordhuis @addaleax
    bnoordhuis authored and addaleax committed Feb 13, 2020
    Configuration menu
    Copy the full SHA
    303e2fd View commit details
    Browse the repository at this point in the history
Loading