Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: d06820c624554df89e77cea4afd68a2ca58549a5
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 6b48324363723dcd0e11444043b6c11f35d52ce2
Choose a head ref
  • 2 commits
  • 5 files changed
  • 1 contributor

Commits on Jun 13, 2016

  1. test: rebuild add-ons when their sources change 

    The prerequisite for rebuilding was on the binding.gyp file but the
actual sources.

PR-URL: #7262
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    @bnoordhuis
    bnoordhuis committed Jun 13, 2016
    Configuration menu
    Copy the full SHA
    9ce8882 View commit details
    Browse the repository at this point in the history

  2. src: fix erroneous fallthrough in ParseEncoding() 

    A missing 'break' statement unintentionally allowed "linary"
and "luffer" as alternatives for "binary" and "buffer".

Regression introduced in commit 54cc721 ("buffer: introduce latin1
encoding term".)

PR-URL: #7262
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    @bnoordhuis
    bnoordhuis committed Jun 13, 2016
    Configuration menu
    Copy the full SHA
    6b48324 View commit details
    Browse the repository at this point in the history
Loading