Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: c380ee6785b72fd2f24803de80bb412dfc32e8a9
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 11b34a916fefd67a89f3188c4c49acb9c7a297ac
Choose a head ref
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on Dec 31, 2020

  1. string_decoder: throw ERR_STRING_TOO_LONG for UTF-8 

    String::NewFromUtf8 doesn't generate an exception in V8 when the string
is too long but is guaranteed to return an empty MaybeLocal only in
that case. Generate a Node.js exception when it happens.

Fixes: #35676

PR-URL: #36661
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @targos @nodejs-github-bot
    targos authored and nodejs-github-bot committed Dec 31, 2020
    Configuration menu
    Copy the full SHA
    11b34a9 View commit details
    Browse the repository at this point in the history
Loading