Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: c2aedd0310f2efdeb2ae69e14ae9950880bde24a
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 6d6de56571290412e052420f6425e0adb2eed1b2
Choose a head ref
  • 6 commits
  • 26 files changed
  • 1 contributor

Commits on Apr 6, 2020

  1. src: make creating per-binding data structures easier 

    Enable the state associated with the individual bindings, e.g. fs or
http2, to be moved out of the Environment class, in order for these
to be more modular and for Environment to be come less of a collection
of random data fields.

Do this by using a BaseObject as the data for callbacks, which can hold
the per-binding state. By default, no per-binding state is available,
although that can be configured when setting up the binding.

PR-URL: #32538
Reviewed-By: James M Snell <jasnell@gmail.com>
    @addaleax
    addaleax committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    6576b9b View commit details
    Browse the repository at this point in the history

  2. src: move HTTP/2 state out of Environment 

    Moves state that is specific to HTTP/2 into the HTTP/2 implementation
as a cleanup.

PR-URL: #32538
Reviewed-By: James M Snell <jasnell@gmail.com>
    @addaleax
    addaleax committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    f54b5b2 View commit details
    Browse the repository at this point in the history

  3. src: move v8 stats buffers out of Environment 

    Moves state that is specific to the `v8` binding into the
`v8` binding implementation as a cleanup.

PR-URL: #32538
Reviewed-By: James M Snell <jasnell@gmail.com>
    @addaleax
    addaleax committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    c47d042 View commit details
    Browse the repository at this point in the history

  4. src: move http parser state out of Environment 

    Moves state that is specific to HTTP/1 into the HTTP/1 implementation
as a cleanup.

PR-URL: #32538
Reviewed-By: James M Snell <jasnell@gmail.com>
    @addaleax
    addaleax committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    1216e8f View commit details
    Browse the repository at this point in the history

  5. src: move fs state out of Environment 

    Moves state that is specific to the `fs` binding into the
`fs` binding implementation as a cleanup.

PR-URL: #32538
Reviewed-By: James M Snell <jasnell@gmail.com>
    @addaleax
    addaleax committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    f4c2dff View commit details
    Browse the repository at this point in the history

  6. src,doc: add documentation for per-binding state pattern 

    PR-URL: #32538
Reviewed-By: James M Snell <jasnell@gmail.com>
    @addaleax
    addaleax committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    6d6de56 View commit details
    Browse the repository at this point in the history
Loading