Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: c0e6e60cb18878745c433a712443f01b6c2a716d
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: e88960d1f4bfc9e8fc15aa4e5e42241e24f01e33
Choose a head ref
  • 11 commits
  • 29 files changed
  • 9 contributors

Commits on Apr 3, 2020

  1. esm: import.meta.resolve with nodejs: builtins 

    Backport-PR-URL: #32610
PR-URL: #31032
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
    @guybedford @MylesBorins
    guybedford authored and MylesBorins committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    05091d4 View commit details
    Browse the repository at this point in the history

  2. module: package "exports" error refinements 

    Backport-PR-URL: #32610
PR-URL: #31625
Reviewed-By: Jan Krems <jan.krems@gmail.com>
    @guybedford @MylesBorins
    guybedford authored and MylesBorins committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    c537afb View commit details
    Browse the repository at this point in the history

  3. esm: remove unused parameter on module.instantiate 

    Backport-PR-URL: #32610
PR-URL: #32147
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    @himself65 @MylesBorins
    himself65 authored and MylesBorins committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    0e513b2 View commit details
    Browse the repository at this point in the history

  4. module: add hook for global preload code 

    Backport-PR-URL: #32610
PR-URL: #32068
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
    @hybrist @MylesBorins
    hybrist authored and MylesBorins committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    62b5bd4 View commit details
    Browse the repository at this point in the history

  5. doc: import clarifications with links to MDN 

    Backport-PR-URL: #32610
PR-URL: #31479
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
    @aldeed @MylesBorins
    aldeed authored and MylesBorins committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    8b96134 View commit details
    Browse the repository at this point in the history

  6. doc: improve wording in esm.md 

    Simplify complex sentence. Remove use of "straightforward".

Backport-PR-URL: #32610
PR-URL: #32427
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    @Trott @MylesBorins
    Trott authored and MylesBorins committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    d8e17bf View commit details
    Browse the repository at this point in the history

  7. doc: fix lint warning in doc/api/esm.md 

    Signed-off-by: Richard Lau <riclau@uk.ibm.com>

Backport-PR-URL: #32610
PR-URL: #32462
Refs: #31479
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    @richardlau @MylesBorins
    richardlau authored and MylesBorins committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    61f44c9 View commit details
    Browse the repository at this point in the history

  8. doc: remove unnecessary "obvious(ly)" modifiers in esm.md 

    Remove "obvious" and "obviously" in two places in esm.md. It may be
obvious to some, but likely not everyone or else it probably wouldn't be
worth mentioning/documenting.

Backport-PR-URL: #32610
PR-URL: #32457
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
    @Trott @MylesBorins
    Trott authored and MylesBorins committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    7e56e3d View commit details
    Browse the repository at this point in the history

  9. build: add mjs extension to lint-js 

    This matches what the lint-js make target passes through the CLI.

Backport-PR-URL: #32610
PR-URL: #32145
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    @nschonni @MylesBorins
    nschonni authored and MylesBorins committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    45d05e1 View commit details
    Browse the repository at this point in the history

  10. doc: update conditional exports recommendations 

    Backport-PR-URL: #32610
Co-Authored-By: Geoffrey Booth <GeoffreyBooth@users.noreply.github.com>
PR-URL: #32098
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
    @guybedford @GeoffreyBooth @MylesBorins
    2 people authored and MylesBorins committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    155a6c3 View commit details
    Browse the repository at this point in the history

  11. doc: esm spec bug 

    PR-URL: #32610
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
    @MylesBorins
    MylesBorins committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    e88960d View commit details
    Browse the repository at this point in the history
Loading