Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: bf26c44c9296e807fea5d5693464e69cf26a6eb4
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 89692ff19b9a4ce03a7f4d4e6949fd2a0a2d6fd2
Choose a head ref
  • 4 commits
  • 1,723 files changed
  • 2 contributors

Commits on Mar 24, 2020

  1. deps: upgrade openssl sources to 1.1.1e 

    This updates all sources in deps/openssl/openssl by:
    $ cd deps/openssl/
    $ rm -rf openssl
    $ tar zxf ~/tmp/openssl-1.1.1e.tar.gz
    $ mv openssl-1.1.1e openssl
    $ git add --all openssl
    $ git commit openssl

PR-URL: #32328
Backport-PR-URL: #32443
Fixes: #32210
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @hassaanp @BethGriggs
    hassaanp authored and BethGriggs committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    c8f5ab2 View commit details
    Browse the repository at this point in the history

  2. deps: adjust openssl configuration for 1.1.1e 

    The scripts used by make were modified to correctly reference the source
files that were originially in crypto/include/internal, but got moved to
include/crypto.  The base path has been left unaltered since that would
require too many changes

PR-URL: #32328
Backport-PR-URL: #32443
Fixes: #32210
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @hassaanp @BethGriggs
    hassaanp authored and BethGriggs committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    64c1848 View commit details
    Browse the repository at this point in the history

  3. deps: update archs files for OpenSSL-1.1.1e 

    After an OpenSSL source update, all the config files need to be
regenerated and comitted by:
    $ cd deps/openssl/config
    $ make
    $ git add deps/openssl/config/archs
    $ git add deps/openssl/include

PR-URL: #32328
Backport-PR-URL: #32443
Fixes: #32210
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @hassaanp @BethGriggs
    hassaanp authored and BethGriggs committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    76033c5 View commit details
    Browse the repository at this point in the history

  4. test: end tls connection with some data 

    In openssl-1.1.1e the client doesn't seem to like having the TLS
connection shut down with no data sent, so send an empty string. A
number of related issues showed up in the TLS1.3 port, so this is
not entirely surprising.

PR-URL: #32328
Backport-PR-URL: #32443
Fixes: #32210
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @sam-github @BethGriggs
    sam-github authored and BethGriggs committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    89692ff View commit details
    Browse the repository at this point in the history
Loading