Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: b1094dbe19f31f7a69ad16d193748f610b159073
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: b5ea925c8e30aa85f1821f3bd9833b52608bf91e
Choose a head ref
  • 3 commits
  • 2 files changed
  • 1 contributor

Commits on Mar 27, 2019

  1. util: increase function length when using callbackify() 

    The returned function from `util.callbackify()` should increase the
`length` property by one due to the added callback.

PR-URL: #26893
Fixes: #26890
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
    @BridgeAR
    BridgeAR committed Mar 27, 2019
    Configuration menu
    Copy the full SHA
    61d1334 View commit details
    Browse the repository at this point in the history

  2. util: rename callbackified function 

    This makes sure the function returned by `util.callbackify()` has a
new name that is not identical to the inputs function name.

PR-URL: #26893
Fixes: #26890
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
    @BridgeAR
    BridgeAR committed Mar 27, 2019
    Configuration menu
    Copy the full SHA
    46bf0d0 View commit details
    Browse the repository at this point in the history

  3. util: don't set the prototype of callbackified functions 

    Using `util.callbackify()` should not set the prototype for the
returned function to the one from the input function. It could cause
confusion while debugging otherwise.

PR-URL: #26893
Fixes: #26890
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
    @BridgeAR
    BridgeAR committed Mar 27, 2019
    Configuration menu
    Copy the full SHA
    b5ea925 View commit details
    Browse the repository at this point in the history
Loading