Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: acb49dc04d3700398f58fec2011661383077b638
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 00944c7cc25f391c3fbeba1e054a56a62cf0de12
Choose a head ref
  • 5 commits
  • 16 files changed
  • 1 contributor

Commits on Dec 28, 2018

  1. tls: remove unused ocsp extension parsing 

    The OCSP info from parsing the TLS ClientHello has not been used since
550c263, remove it.

See: #1464

PR-URL: #25153
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    @sam-github
    sam-github committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    08387b2 View commit details
    Browse the repository at this point in the history

  2. tls: fix initRead socket argument name 

    "wrapped" argument is the caller's "socket", not its "wrap", and its
referred to as "socket" in the comments, so call it that.

PR-URL: #25153
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    @sam-github
    sam-github committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    59aa941 View commit details
    Browse the repository at this point in the history

  3. tls: do not confuse TLSSocket and Socket 

    Don't use "socket" to describe two different objects in the same
function.

PR-URL: #25153
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    @sam-github
    sam-github committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    b50c22a View commit details
    Browse the repository at this point in the history

  4. tls: do not confuse session and session ID 

    session ID was named session in C++ and key in JS, Name them after what
they are, as the 'newSession' event docs do.

PR-URL: #25153
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    @sam-github
    sam-github committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    03e23a3 View commit details
    Browse the repository at this point in the history

  5. src: use consistent names for JSStream 

    Its confusing to call a js class with a handle a "Wrap", usually it's
the C++ handle that is called a Wrap (tcp_wrap, tls_wrap, ...). Its
derived from Socket, and makes a JS stream look like a Socket, so call
it that. Also, remove use of lib/_stream_wrap.js so it can be deprecated
some time.

PR-URL: #25153
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    @sam-github
    sam-github committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    00944c7 View commit details
    Browse the repository at this point in the history
Loading