Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 963ee0bc736008e01d80fbad973f80fd021735fd
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: eb0bf8d3077f7fd4d09f187b8bb8290ec8f8171b
Choose a head ref
  • 2 commits
  • 12 files changed
  • 1 contributor

Commits on Mar 11, 2019

  1. src: refactor coverage connection 

    - Refactor the C++ class to be resuable for other types of profiles
- Move the try-catch block around coverage collection callback
  to be inside the callback to silence potential JSON or write
  errors.
- Use Function::Call instead of MakeCallback to call the coverage
  message callback since it does not actually need async hook
  handling. This way we no longer needs to disable the async
  hooks when writing the coverage results.
- Renames `lib/internal/coverage-gen/with_profiler.js` to
  `lib/internal/profiler.js` because it is now the only way
  to generate coverage.

PR-URL: #26513
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Coe <bencoe@gmail.com>
    @joyeecheung
    joyeecheung committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    0a3bcdd View commit details
    Browse the repository at this point in the history

  2. test: show stderr on v8 coverage test failures 

    PR-URL: #26513
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Coe <bencoe@gmail.com>
    @joyeecheung
    joyeecheung committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    eb0bf8d View commit details
    Browse the repository at this point in the history
Loading