Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 9037ad3e78324be6952ea114bf1fd701a2803516
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 6ca6db105d8db40af538e275f39612b569b9c141
Choose a head ref
  • 2 commits
  • 3 files changed
  • 1 contributor

Commits on Apr 28, 2020

  1. wasi: rename __wasi_unstable_reactor_start() 

    Upstream WASI has renamed __wasi_unstable_reactor_start() to
_initialize(). This commit updates Node's WASI implementation to
reflect that change.

PR-URL: #33073
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
    @cjihrig
    cjihrig committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    4791ea0 View commit details
    Browse the repository at this point in the history

  2. wasi: update start() behavior to match spec 

    _start() and _initialize() shouldn't be called from the same
function, as they have different behavior. Furthermore, Node
should throw if both are provided. This commit updates the
implementation, docs, and tests accordingly.

PR-URL: #33073
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
    @cjihrig
    cjihrig committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    6ca6db1 View commit details
    Browse the repository at this point in the history
Loading