Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 7e60292c8fa638983bd365e78558f7c49a9bcb22
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 09099ab9f481934ff0d74e801533c7048729aa6f
Choose a head ref
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Sep 4, 2016

  1. deps: MASM.UseSafeExceptionHandlers for OpenSSL 

    Use `msvs_settings.MASM.UseSafeExceptionHandlers` when building OpenSSL
assembly code on Windows. This option appends `/safeseh` to the list of
assembler flags when building `.asm` files on Windows.

Having this option in place, separate rules in `masm_compile.gypi` are
no longer needed.

Fix: #7426
PR-URL: #7427
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bert Belder <bertbelder@gmail.com>
    @indutny @MylesBorins
    indutny authored and MylesBorins committed Sep 4, 2016
    Configuration menu
    Copy the full SHA
    ef977f6 View commit details
    Browse the repository at this point in the history

  2. deps: no /safeseh for ml64.exe 

    `ml64.exe` doesn't support `/safeseh` option. Do not attempt to use it
if `target_arch=="x64"`.

See: https://msdn.microsoft.com/en-us/library/s0ksfwcf.aspx
PR-URL: #7759
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
    @indutny @MylesBorins
    indutny authored and MylesBorins committed Sep 4, 2016
    Configuration menu
    Copy the full SHA
    09099ab View commit details
    Browse the repository at this point in the history
Loading