Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 7af8e20ee8e96b3d1ae90e9d5195dcc828a72418
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: b3041a0838d2a329e4239430cadf2160b9fda1a8
Choose a head ref
  • 6 commits
  • 33 files changed
  • 2 contributors

Commits on Dec 20, 2023

  1. src: make process binding data weak 

    Avoid the realm being strongly referenced by the process binding data.

PR-URL: #48655
Backport-PR-URL: #51239
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    @legendecas @UlisesGascon
    legendecas authored and UlisesGascon committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    444affd View commit details
    Browse the repository at this point in the history

  2. src: create worker per isolate properties 

    PR-URL: #48655
Backport-PR-URL: #51239
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    @legendecas @UlisesGascon
    legendecas authored and UlisesGascon committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    eb7170c View commit details
    Browse the repository at this point in the history

  3. src: create fs_dir per isolate properties 

    PR-URL: #48655
Backport-PR-URL: #51239
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    @legendecas @UlisesGascon
    legendecas authored and UlisesGascon committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    6b9892b View commit details
    Browse the repository at this point in the history

  4. src: create per isolate proxy env template 

    PR-URL: #48655
Backport-PR-URL: #51239
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    @legendecas @UlisesGascon
    legendecas authored and UlisesGascon committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    23a86e5 View commit details
    Browse the repository at this point in the history

  5. module: remove useCustomLoadersIfPresent flag 

    The flag is always true and can be determined by isLoaderWorker solely.

PR-URL: #48655
Backport-PR-URL: #51239
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    @legendecas @UlisesGascon
    legendecas authored and UlisesGascon committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    ec63a13 View commit details
    Browse the repository at this point in the history

  6. module: bootstrap module loaders in shadow realm 

    This bootstraps ESM loaders in the ShadowRealm with
`ShadowRealm.prototype.importValue` as its entry point and enables
loading ESM and CJS modules in the ShadowRealm. The module is imported
without a parent URL and resolved with the current process's working
directory.

PR-URL: #48655
Backport-PR-URL: #51239
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    @legendecas @UlisesGascon
    legendecas authored and UlisesGascon committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    b3041a0 View commit details
    Browse the repository at this point in the history
Loading