Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 765be6c2e14da3d4649a3a2c1ccb605d518e8e96
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: a3132b0aa5721ffb8ed0ee150b9f2486449f60bb
Choose a head ref
  • 2 commits
  • 3 files changed
  • 1 contributor

Commits on Apr 29, 2017

  1. test: support multiple warnings in checkWarning 

    This allows the common.checkWarning() test method to accept a map of
warning names to description(s), to allow testing code that generates
multiple types of warnings.

PR-URL: #11640
Reviewed-By: Anna Henningsen <anna@addaleax.net>
    @apexskier @addaleax
    apexskier authored and addaleax committed Apr 29, 2017
    Configuration menu
    Copy the full SHA
    74f61e8 View commit details
    Browse the repository at this point in the history

  2. process: cast promise rejection reason to string 

    The unhandled promise rejection warning uses a template literal and
prints the reason a promise was rejected. If rejecting with a symbol,
the symbol failed to convert to a string and the process crashed. Now,
symbols are casted to strings and the process does not crash.

Fixes: #11637
PR-URL: #11640
Reviewed-By: Anna Henningsen <anna@addaleax.net>
    @apexskier @addaleax
    apexskier authored and addaleax committed Apr 29, 2017
    Configuration menu
    Copy the full SHA
    a3132b0 View commit details
    Browse the repository at this point in the history
Loading