Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 73f13ba2fceccea61629f66ceba4f2fea832bd9f
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: c974f1bbe835f66218a15456ca9f8faee6b85c91
Choose a head ref
  • 2 commits
  • 6 files changed
  • 1 contributor

Commits on Apr 15, 2018

  1. deps: cherry-pick 39d546a from upstream V8 

    Original commit message:

    [api] introduce v8::Value::IsModuleNamespaceObject

    This allows an embedder to check if a Value is a module namespace object.

    Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
    Change-Id: Idffceff451dd5f5c6a53d4cb3ce02c1c2c5b653c
    Reviewed-on: https://chromium-review.googlesource.com/1011762
    Reviewed-by: Georg Neis <neis@chromium.org>
    Commit-Queue: Georg Neis <neis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#52597}

Refs: v8/v8@39d546a

PR-URL: #20016
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    @devsnek
    devsnek committed Apr 15, 2018
    Configuration menu
    Copy the full SHA
    ebe499f View commit details
    Browse the repository at this point in the history

  2. util: introduce types.isModuleNamespaceObject 

    PR-URL: #20016
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    @devsnek
    devsnek committed Apr 15, 2018
    Configuration menu
    Copy the full SHA
    c974f1b View commit details
    Browse the repository at this point in the history
Loading