Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 73324cf76a1898d45d887a44145e7ab12236c076
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 38146e717fed2fabe3aacb6540d839475e0ce1c6
Choose a head ref
  • 3 commits
  • 3 files changed
  • 1 contributor

Commits on Apr 28, 2020

  1. crypto: key size must be int32 in DiffieHellman() 

    The JS code accepted any value where `typeof sizeOrKey === 'number'`
was true but the C++ code checked that `args[0]->IsInt32()` and
subsequently aborted.

Fixes: #32738

PR-URL: #32739
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @bnoordhuis @addaleax
    bnoordhuis authored and addaleax committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    6fdced4 View commit details
    Browse the repository at this point in the history

  2. crypto: generator must be int32 in DiffieHellman() 

    Validate the generator argument in `crypto.createDiffieHellman(key, g)`.
When it's a number, it should be an int32.

Fixes: #32748

PR-URL: #32739
Fixes: #32738
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @bnoordhuis @addaleax
    bnoordhuis authored and addaleax committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    0694401 View commit details
    Browse the repository at this point in the history

  3. crypto: check DiffieHellman p and g params 

    It's possible to pass in the prime and generator params as buffers
but that mode of input wasn't as rigorously checked as numeric input.

PR-URL: #32739
Fixes: #32738
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @bnoordhuis @addaleax
    bnoordhuis authored and addaleax committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    38146e7 View commit details
    Browse the repository at this point in the history
Loading