Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 6e9551e1b1b7e204b1e5497606c43dae59a16523
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 7d201c4e700ff94f17dab9185c03c44597976e8c
Choose a head ref
  • 2 commits
  • 1 file changed
  • 1 contributor

Commits on Mar 22, 2019

  1. test: fix pummel/test-tls-session-timeout 

    The test does not work with TLS 1.3 nor should it. Force TLS version
1.2.

While at it, some refactoring:

* refresh the tmp directory in case it doesn't exist!
* add an assert.strictEqual() check on the client return `code` value
  which must be zero
* use arrow functions for callbacks
* add trailing commas for multiline arrays/objects

Fixes: #26839

PR-URL: #26865
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    @Trott
    Trott committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    cc89e68 View commit details
    Browse the repository at this point in the history

  2. test: move pummel tls test to sequential 

    Move test-tls-session-timeout from pummel to sequential. It isn't very
pummel-y and this will result in it being run on our CI more than once a
day. (It broke recently and it would have been caught if it was in
sequential rather than pummel.)

It must be in sequential rather than pummel because it uses
`common.PORT` which can result in test failures if more than one test
uses it at one time in parallel.

PR-URL: #26865
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    @Trott
    Trott committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    7d201c4 View commit details
    Browse the repository at this point in the history
Loading