Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 6b2af91a88b0a5e4d846701971065b8d668c8b1d
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2190d47d604641d26acc2ef6c1b6a9ad00afa193
Choose a head ref
  • 2 commits
  • 4 files changed
  • 1 contributor

Commits on Jan 16, 2019

  1. src: pass cli options to bootstrap/loaders.js lexically 

    Instead of using `internalBinding('config')` which should be used
to carry information about build-time options, directly pass the
run-time cli options into bootstrap/loaders.js lexically via
function arguments.

PR-URL: #25463
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
    @joyeecheung
    joyeecheung committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    cd70cbc View commit details
    Browse the repository at this point in the history

  2. src: remove unused internalBinding('config') properties 

    Remove the following properties:

- `preserveSymlinks`
- `preserveSymlinksMain`
- `experimentalModules`
- `userLoader`
- `experimentalVMModules`
- `experimentalREPLAwait`
- `exposeInternals`

We used to use them to pass cli option values from C++ into
JS, but now the values are obtained in JS land using
`require('internal/options').getOptionValue` instead so they
are unused.

Also removes `test/parallel/test-internal-modules-expose.js`
which tests `--expose-internals`.
We already have hundreds of tests depending on `--expose-internals`,
they are more than enough to test the functionality of the flag.

PR-URL: #25463
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
    @joyeecheung
    joyeecheung committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    2190d47 View commit details
    Browse the repository at this point in the history
Loading