Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 6b1a40e91492d7b3691db07f0522dcdbbd47bd4f
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 35471bcfdffaa9624792a510ad04cbb4c8709193
Choose a head ref
  • 3 commits
  • 3 files changed
  • 2 contributors

Commits on Feb 20, 2018

  1. events: move domain handling from events to domain 

    Backport-PR-URL: #18487
PR-URL: #17403
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    @vdeturckheim @MylesBorins
    vdeturckheim authored and MylesBorins committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    3ae5cf2 View commit details
    Browse the repository at this point in the history

  2. events: use Reflect.apply 

    Instead of callback bound apply, instead use the standard
Reflect.apply. This is both safer and appears to offer
a slight performance benefit.

Backport-PR-URL: #18487
PR-URL: #17456
Refs: #12956
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    @apapirovski @MylesBorins
    apapirovski authored and MylesBorins committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    28edc1d View commit details
    Browse the repository at this point in the history

  3. domain: fix error emit handling 

    Fix an issue where error is never emitted on the original EventEmitter
in situations where a listener for error does exist.

Refactor to eliminate unnecessary try/catch/finally block.

Backport-PR-URL: #18487
PR-URL: #17588
Refs: #17403
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @apapirovski @MylesBorins
    apapirovski authored and MylesBorins committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    35471bc View commit details
    Browse the repository at this point in the history
Loading