Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 66e26cd253a1b65d243aa67d95e415ae392e4858
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 02e6c84de23e833033163c64bf0a5c9fab7829e4
Choose a head ref
  • 6 commits
  • 6 files changed
  • 3 contributors

Commits on Nov 22, 2016

  1. deps: make gtest output tap 

    Teach gtest to produce TAP so we can integrate it better with our CI
tooling.

TAP is printed to stdout but it can also be written to file by passing
the `--gtest_output=tap:filename.tap` switch to cctest.

PR-URL: #8034
Reviewed-By: James M Snell <jasnell@gmail.com>
    @bnoordhuis Myles Borins
    bnoordhuis authored and Myles Borins committed Nov 22, 2016
    Configuration menu
    Copy the full SHA
    4c47446 View commit details
    Browse the repository at this point in the history

  2. build: run cctests as part of test-ci target 

    Enable the cctests on the CI now that they know how to write TAP output.

PR-URL: #8034
Reviewed-By: James M Snell <jasnell@gmail.com>
    @bnoordhuis Myles Borins
    bnoordhuis authored and Myles Borins committed Nov 22, 2016
    Configuration menu
    Copy the full SHA
    7c73105 View commit details
    Browse the repository at this point in the history

  3. deps: revert default gtest reporter change 

    PR-URL: #8948
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @mscdex Myles Borins
    mscdex authored and Myles Borins committed Nov 22, 2016
    Configuration menu
    Copy the full SHA
    eb34f68 View commit details
    Browse the repository at this point in the history

  4. test: output tap13 instead of almost-tap 

    Produce a tap13-compatible output which makes it
simpler to parse. Output is still readable by
the jenkins tap plugin.

PR-URL: #9262
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
    @jbergstroem Myles Borins
    jbergstroem authored and Myles Borins committed Nov 22, 2016
    Configuration menu
    Copy the full SHA
    747013b View commit details
    Browse the repository at this point in the history

  5. gtest: output tap comments as yamlish 

    This makes yaml-ish parsers happy.
Note: gtest still seems to output the expected/result slightly
different making the full traceback less informational.

PR-URL: #9262
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
    @jbergstroem Myles Borins
    jbergstroem authored and Myles Borins committed Nov 22, 2016
    Configuration menu
    Copy the full SHA
    36abbbe View commit details
    Browse the repository at this point in the history

  6. gitignore: ignore all tap files 

    We now have multiple tap producers; just ignore all
files with the `.tap` extension.

PR-URL: #9262
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
    @jbergstroem Myles Borins
    jbergstroem authored and Myles Borins committed Nov 22, 2016
    Configuration menu
    Copy the full SHA
    02e6c84 View commit details
    Browse the repository at this point in the history
Loading