Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 659c45856d3c7f50cb4cdcd6a9b4348e9af8c536
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 8ade20fd4fe252fc65ffe5d2dc4ef497ee7e5b33
Choose a head ref
  • 2 commits
  • 1 file changed
  • 1 contributor

Commits on Nov 26, 2017

  1. fs: fix stat dev unsigned cast overflow 

    The `dev_t` is unsigned on Linux, use Integer::NewFromUnsigned to fix cast overflow

PR-URL: #16705
Fixes: #16496
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    @JLHwung @MylesBorins
    JLHwung authored and MylesBorins committed Nov 26, 2017
    Configuration menu
    Copy the full SHA
    972ef1a View commit details
    Browse the repository at this point in the history

  2. fs: use Number::New since all fields are uint64_t 

    PR-URL: #16705
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    @JLHwung @MylesBorins
    JLHwung authored and MylesBorins committed Nov 26, 2017
    Configuration menu
    Copy the full SHA
    8ade20f View commit details
    Browse the repository at this point in the history
Loading