Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 5f07d00c60729d6b73b7f468d3094331c8708950
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: a4795ada8b0c725cafc6f5e0ffbc864cd09b9db7
Choose a head ref
  • 3 commits
  • 4 files changed
  • 1 contributor

Commits on Jan 1, 2022

  1. src: guard slightly costly check in MakeCallback more strongly 

    PR-URL: #41331
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
    @addaleax @nodejs-github-bot
    addaleax authored and nodejs-github-bot committed Jan 1, 2022
    Configuration menu
    Copy the full SHA
    6932fb8 View commit details
    Browse the repository at this point in the history

  2. src: store native async execution resources as v8::Local 

    This is possible because the async stack is always expected
to match the native call stack, and saves performance overhead
that comes from the usage of `v8::Global`.

PR-URL: #41331
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
    @addaleax @nodejs-github-bot
    addaleax authored and nodejs-github-bot committed Jan 1, 2022
    Configuration menu
    Copy the full SHA
    69ea677 View commit details
    Browse the repository at this point in the history

  3. src: split out async stack corruption detection from inline fn 

    This is fairly expensive code that unnecessarily bloats the
contents of the inline function.

PR-URL: #41331
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
    @addaleax @nodejs-github-bot
    addaleax authored and nodejs-github-bot committed Jan 1, 2022
    Configuration menu
    Copy the full SHA
    a4795ad View commit details
    Browse the repository at this point in the history
Loading