Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 5d910ca389b3e1b956a3e888a710dff81b524958
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 6f3a8b45a5f02aa87987a0a2ea48c74fefa9fcc6
Choose a head ref
  • 20 commits
  • 28 files changed
  • 5 contributors

Commits on Jul 12, 2023

  1. url: remove unused kFormat from url 

    PR-URL: #46867
Backport-PR-URL: #48345
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    @anonrig @danielleadams
    anonrig authored and danielleadams committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    3db235b View commit details
    Browse the repository at this point in the history

  2. url: offload URLSearchParams initialization 

    PR-URL: #46867
Backport-PR-URL: #48345
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    @anonrig @danielleadams
    anonrig authored and danielleadams committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    c79e1b7 View commit details
    Browse the repository at this point in the history

  3. url: set formatUrl method as no side effect 

    PR-URL: #46884
Backport-PR-URL: #48345
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    @anonrig @danielleadams
    anonrig authored and danielleadams committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    aa4f485 View commit details
    Browse the repository at this point in the history

  4. url: backport non-major changes from #46904 

    PR-URL: #46904
Backport-PR-URL: #48345
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    @anonrig @danielleadams
    anonrig authored and danielleadams committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    f495cb6 View commit details
    Browse the repository at this point in the history

  5. url: allow extension of user provided URL objects 

    PR-URL: #46989
Backport-PR-URL: #48345
Fixes: #46981
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    @aduh95 @danielleadams
    aduh95 authored and danielleadams committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    4784e64 View commit details
    Browse the repository at this point in the history

  6. url: fix array overrun in node:url::SetArgs() 

    PR-URL: #47001
Backport-PR-URL: #48345
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
    @anonrig @danielleadams
    anonrig authored and danielleadams committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    977a8ba View commit details
    Browse the repository at this point in the history

  7. src: use std::array for passing argv in node::url 

    Implements a review suggestion from 72e971e.

Refs: #47001 (comment)
PR-URL: #47035
Backport-PR-URL: #48345
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    @addaleax @danielleadams
    addaleax authored and danielleadams committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    1f2c91f View commit details
    Browse the repository at this point in the history

  8. url: implement URL.canParse 

    PR-URL: #47179
Backport-PR-URL: #48345
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    @KhafraDev @danielleadams
    KhafraDev authored and danielleadams committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    11f48e0 View commit details
    Browse the repository at this point in the history

  9. deps: update ada to 2.0.0 

    PR-URL: #47339
Backport-PR-URL: #48345
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
    @nodejs-github-bot @danielleadams
    nodejs-github-bot authored and danielleadams committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    96c50ba View commit details
    Browse the repository at this point in the history

  10. url: use ada::url_aggregator for parsing urls 

    PR-URL: #47339
Backport-PR-URL: #48345
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
    @anonrig @danielleadams
    anonrig authored and danielleadams committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    b395b16 View commit details
    Browse the repository at this point in the history

  11. url: drop ICU requirement for parsing hostnames 

    PR-URL: #47339
Backport-PR-URL: #48345
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
    @anonrig @danielleadams
    anonrig authored and danielleadams committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    0dc485e View commit details
    Browse the repository at this point in the history

  12. url: handle URL.canParse without base parameter 

    PR-URL: #47547
Backport-PR-URL: #48345
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    @anonrig @danielleadams
    anonrig authored and danielleadams committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    8897305 View commit details
    Browse the repository at this point in the history

  13. deps: update ada to 2.1.0 

    PR-URL: #47598
Backport-PR-URL: #48345
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
    @nodejs-github-bot @danielleadams
    nodejs-github-bot authored and danielleadams committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    08dd271 View commit details
    Browse the repository at this point in the history

  14. deps: update ada to 2.2.0 

    PR-URL: #47678
Backport-PR-URL: #48345
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    @nodejs-github-bot @danielleadams
    nodejs-github-bot authored and danielleadams committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    42e690f View commit details
    Browse the repository at this point in the history

  15. deps: update ada to 2.3.0 

    PR-URL: #47737
Backport-PR-URL: #48345
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @nodejs-github-bot @danielleadams
    nodejs-github-bot authored and danielleadams committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    2d03d5f View commit details
    Browse the repository at this point in the history

  16. deps: update ada to 2.3.1 

    PR-URL: #47893
Backport-PR-URL: #48345
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
    @nodejs-github-bot @danielleadams
    nodejs-github-bot authored and danielleadams committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    575ddf6 View commit details
    Browse the repository at this point in the history

  17. deps: update ada to 2.4.0 

    PR-URL: #47922
Backport-PR-URL: #48345
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
    @nodejs-github-bot @danielleadams
    nodejs-github-bot authored and danielleadams committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    81b514d View commit details
    Browse the repository at this point in the history

  18. deps: update ada to 2.4.1 

    PR-URL: #48036
Backport-PR-URL: #48345
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    @nodejs-github-bot @danielleadams
    nodejs-github-bot authored and danielleadams committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    a4ee1f6 View commit details
    Browse the repository at this point in the history

  19. deps: update ada to 2.4.2 

    PR-URL: #48092
Backport-PR-URL: #48345
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    @nodejs-github-bot @danielleadams
    nodejs-github-bot authored and danielleadams committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    075b6db View commit details
    Browse the repository at this point in the history

  20. deps: update ada to 2.5.0 

    PR-URL: #48223
Backport-PR-URL: #48345
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    @nodejs-github-bot @danielleadams
    nodejs-github-bot authored and danielleadams committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    6f3a8b4 View commit details
    Browse the repository at this point in the history
Loading