Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 592c6907bfe1922f36240e9df076be1864c3d1bd
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 328642bbb98d6d581f06e5e67b6f2d045e719bd4
Choose a head ref
  • 2 commits
  • 7 files changed
  • 1 contributor

Commits on Mar 11, 2024

  1. test_runner: support source mapped test locations 

    This commit adds support for source mapping test locations
when the --enable-source-maps flag is present.

Fixes: #51392
PR-URL: #52010
Fixes: #51610
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    @cjihrig @nodejs-github-bot
    cjihrig authored and nodejs-github-bot committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    6d625fe View commit details
    Browse the repository at this point in the history

  2. test_runner: use paths for test locations 

    This commit transforms test locations to paths when V8 provides
file URLs (which seems to be for ESM files).

Fixes: #51610
PR-URL: #52010
Fixes: #51392
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    @cjihrig @nodejs-github-bot
    cjihrig authored and nodejs-github-bot committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    328642b View commit details
    Browse the repository at this point in the history
Loading