Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 468bfd3487c5fba678bb6455add59e774ffbcd82
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5c86475e201709ea2e15b3002c547abfbd3e823b
Choose a head ref
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Feb 27, 2020

  1. test: fix usage of invalid common properties 

    PR-URL: #31933
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
    @lundibundi @Trott
    lundibundi authored and Trott committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    2ec9b58 View commit details
    Browse the repository at this point in the history

  2. test: validate common property usage 

    `common` contains multiple 'check'(boolean) properties that will be
false if mistyped and may lead to errors.
This makes sure that the used property exists in the `common`.

PR-URL: #31933
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
    @lundibundi @Trott
    lundibundi authored and Trott committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    5c86475 View commit details
    Browse the repository at this point in the history
Loading