Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 3ffc84a46de9cf623ac680bff72445e372935376
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3b4159c8ed85b6b531b7df09378d67168574d731
Choose a head ref
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Nov 10, 2018

  1. test: simplify regression test for SEGV 

    Test was introduced in 08a5b44 as a regression test, and has evolved
since then. Simplify the test so that it doesn't rely on an undocumented
argument to tls.createSecureCredentials().

See: nodejs/node-v0.x-archive#6690

Confirmation that this reworked test triggers the original bug:

	%) % node
	> process.version
	'v0.10.48'
	> credentials = crypto.createCredentials()
	{ context: {} }
	> context = credentials.context
	{}
	> notcontext = { setOptions: context.setOptions }
	{ setOptions: [Function: setOptions] }
	> notcontext.setOptions()
	node: ../src/node_object_wrap.h:61: static T* node::ObjectWrap::Unwrap(v8::Handle<v8::Object>) [with T = node::crypto::SecureContext]: Assertion `handle->InternalFieldCount() > 0' failed.
	zsh: abort (core dumped)  node

PR-URL: #24241
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    @sam-github @Trott
    sam-github authored and Trott committed Nov 10, 2018
    Configuration menu
    Copy the full SHA
    624a242 View commit details
    Browse the repository at this point in the history

  2. tls: remove unused arg to createSecureContext() 

    The context arg is unused by node or its test suites and undocumented.
Remove it.

PR-URL: #24241
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    @sam-github @Trott
    sam-github authored and Trott committed Nov 10, 2018
    Configuration menu
    Copy the full SHA
    3b4159c View commit details
    Browse the repository at this point in the history
Loading