Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 343ddffc1c025e444f28dbb0ccfefc23815479d3
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: dcba12895ad58275ba5b027c2c5110461dfebf66
Choose a head ref
  • 2 commits
  • 6 files changed
  • 2 contributors

Commits on Jan 21, 2020

  1. module: fix check exports issue in cjs module loading 

    Refs: #31001 (comment)

PR-URL: #31427
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
    @guybedford @Trott
    guybedford authored and Trott committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    c2c3274 View commit details
    Browse the repository at this point in the history

  2. test,module: add test for exports cjs loader check 

    Refs: #31001 (comment)

PR-URL: #31427
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
    @Trott
    Trott committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    dcba128 View commit details
    Browse the repository at this point in the history
Loading