Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 32c04491412a40ac6bea1b717a59141244620028
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: fae680f740b9f1926e875aabd5cea33950c2edbc
Choose a head ref
  • 8 commits
  • 9 files changed
  • 4 contributors

Commits on Apr 2, 2020

  1. src: add build Github Action 

    Backport-PR-URL: #32608
PR-URL: #31153
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    @gengjiawen @MylesBorins
    gengjiawen authored and MylesBorins committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    782f5db View commit details
    Browse the repository at this point in the history

  2. build: add GitHub actions to run linters 

    Add jobs to our GitHub Actions workflow to run our
various lint Makefile targets. The `setup-node` action
used to run the JavaScript linter contains problem
matchers for eslint that will annotate the files in a pull
request if there are failures.

Backport-PR-URL: #32608
PR-URL: #31323
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    @richardlau @MylesBorins
    richardlau authored and MylesBorins committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    d190ee0 View commit details
    Browse the repository at this point in the history

  3. build: fix step name in GitHub Actions workflow 

    The CI workflow doesn't use the matrix strategy so there is no
`${{ matrix.node-version }}` variable to use in the `Use Node.js`
step names.

Backport-PR-URL: #32608
PR-URL: #31323
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    @richardlau @MylesBorins
    richardlau authored and MylesBorins committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    df701f3 View commit details
    Browse the repository at this point in the history

  4. build: fix macos runner type in GitHub Action 

    Backport-PR-URL: #32608
PR-URL: #31327
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
    @himself65 @MylesBorins
    himself65 authored and MylesBorins committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    ad12c82 View commit details
    Browse the repository at this point in the history

  5. build: do not use setup-node in build workflows 

    The setup-node GitHub Action installs problem matchers that happen
to match the warning message format of Visual Studio's C/C++ compiler.
This is resulting in all of our pull requests being annotated with
`Unchanged files with check annotations` which are confusing to new
contributors as they are not due to the changes in the pull request.

The action is used to run `npx envinfo` to dump some information into
the logs before the actual build. All GitHub hosted runners already
have a version of Node.js installed (12.x at the time of this commit)
which we can use to run `envinfo`. Remove the action to avoid using
the problematic problem matcher.

Backport-PR-URL: #32608
PR-URL: #31349
Fixes: #31347
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
    @richardlau @MylesBorins
    richardlau authored and MylesBorins committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    46f83df View commit details
    Browse the repository at this point in the history

  6. build: build docs in GitHub Actions CI workflow 

    Backport-PR-URL: #32608
PR-URL: #31504
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
    @richardlau @MylesBorins
    richardlau authored and MylesBorins committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    c42cb79 View commit details
    Browse the repository at this point in the history

  7. build: annotate markdown lint failures in pull requests 

    Add a problem matcher for output from remark-lint to our lint-md GitHub
Actions CI workflow so that any markdown linter failures are annotated
in the pull request in the web UI.

Signed-off-by: Richard Lau <riclau@uk.ibm.com>

Backport-PR-URL: #32608
PR-URL: #32391
Refs: https://github.com/actions/toolkit/blob/master/docs/problem-matchers.md
Refs: https://github.com/actions/toolkit/blob/master/docs/commands.md#problem-matchers
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
    @richardlau @MylesBorins
    richardlau authored and MylesBorins committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    a506489 View commit details
    Browse the repository at this point in the history

  8. build: drop Travis in favor of Actions 

    GitHub Actions is running all tests already present on Travis, as well
as building on more platforms (OS X and Windows). With Travis we're also
getting timeouts more frequently than with Actions, which gives the
false impression tests are failing (making it harder to triage PRs ready
to merge).

To make our config simpler, CI.yml and pythonpackage.yml got merged. The
coverage is also increased by running tests on OS X.

Signed-off-by: Matheus Marchini <mmarchini@netflix.com>

Backport-PR-URL: #32608
PR-URL: #32450
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
    @cclauss @MylesBorins
    cclauss authored and MylesBorins committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    fae680f View commit details
    Browse the repository at this point in the history
Loading