Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 27a5338c8a33a853a0d543cddfa7b2bab1466638
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: f479050916aa8fdb8bf580c6b103308dd012cdba
Choose a head ref
  • 2 commits
  • 12 files changed
  • 1 contributor

Commits on Aug 1, 2018

  1. src,lib: rename FSReqWrap to FSReqCallback 

    Given that FSReqPromise does not inherit from FSReqWrap, FSReqWrap
should be renamed FSReqCallback to better describe what it does.

First of a few upcoming `fs` refactorings :)

PR-URL: #21971
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    @maclover7
    maclover7 committed Aug 1, 2018
    Configuration menu
    Copy the full SHA
    172b4d7 View commit details
    Browse the repository at this point in the history

  2. src: rename PROVIDER_FSREQWRAP to PROVIDER_FSREQCALLBACK 

    PR-URL: #21971
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    @maclover7
    maclover7 committed Aug 1, 2018
    Configuration menu
    Copy the full SHA
    f479050 View commit details
    Browse the repository at this point in the history
Loading