Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 26f7edbf71979cbf5765ce0af41fb8bfb93bb55a
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0e63d0abd5168defefcaf77db28f8b8d14da1c48
Choose a head ref
  • 4 commits
  • 106 files changed
  • 1 contributor

Commits on Feb 5, 2019

  1. test: cover tls multi-identity option mixtures 

    Prove that cert and key options do not have to be ordered, and that the
pfx option can be used at the same time as the cert/key option
(which was claimed to be impossible by some pre-existing documentation).

Backport-PR-URL: #25501
PR-URL: #24374
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    @sam-github @BethGriggs
    sam-github authored and BethGriggs committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    83145ec View commit details
    Browse the repository at this point in the history

  2. test: add independent multi-alg crypto identities 

    agent6 was the only cert that had a chain (an intermediate certificate),
and there were no non-RSA certs other than a single self-signed one.
This makes it impossible to test cert-chain scenarios with multiple
identities which require chains to prove chain completion, and
multi-algorithm because OpenSSL doesn't support multiple identities
unless they are multi-algorithm.

PFX files were also missing for most identities, making it difficult to
test multi-PFX and PFX interactions with cert-chain+key and CA options.

New server cert chains:

- ECC: ca5 signs ca6 signs ec10, CN=agent10.example.com
- RSA: ca2 signs ca4 signs agent10, CN=agent10.example.com

PFX added for:

- agent6
- agent10
- ec10

All pem and pfx regenerated from scratch to test that the Makefile is
actually working as intended.

Backport-PR-URL: #25501
PR-URL: #24374
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    @sam-github @BethGriggs
    sam-github authored and BethGriggs committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    43dcbbe View commit details
    Browse the repository at this point in the history

  3. test: rename agent1-pfx.pem to agent1.pfx 

    PFX is not PEM, its binary DER. Use the same .pfx extension as
test/fixtures/test_cert.pfx does.

Backport-PR-URL: #25501
PR-URL: #24374
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    @sam-github @BethGriggs
    sam-github authored and BethGriggs committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    3c2b40b View commit details
    Browse the repository at this point in the history

  4. test: confirm tls server suite default is its own 

    When honorCipherOrder is not explicitly set, it defaults to true, cover
this condition in the test. Also, run all tests in parallel, instead of
sequentially.

Backport-PR-URL: #25501
PR-URL: #24374
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    @sam-github @BethGriggs
    sam-github authored and BethGriggs committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    0e63d0a View commit details
    Browse the repository at this point in the history
Loading