Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1d631ce9a8d47a021d9ebbf9de3225c3672b80d9
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2ebceed790641ee73026cf3c81785a7e957f161e
Choose a head ref
  • 5 commits
  • 30 files changed
  • 1 contributor

Commits on Mar 2, 2017

  1. v8: fix --always-opt bug 

    Don't try to optimize known-unoptimizable functions when --always-opt
is specified on the command line, it makes Crankshaft emit wrong code.

This was fixed upstream when improved WASM support was introduced but
that specific change can't be back-ported because it depends on prior
work that doesn't exist in V8 5.1.  Ergo, I decided to redo the fix
from scratch.

PR-URL: #9293
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
    @bnoordhuis
    bnoordhuis committed Mar 2, 2017
    Configuration menu
    Copy the full SHA
    daa56a6 View commit details
    Browse the repository at this point in the history

  2. deps: back-port 306c412c from v8 upstream 

    The patch has been modified to maintain ABI compatibility.  The original
change removes the v8::FunctionCallbackInfo<T>::is_construct_call_ field
from deps/v8/include/v8.h.  The field is set directly by JIT-ted code so
the removal of those code paths has been backed out as well.

Original commit message:

    [api] Expose FunctionCallbackInfo::NewTarget

    This is needed by Blink to implement the Custom Elements spec.

    BUG=v8:4261
    LOG=y

    Review-Url: https://codereview.chromium.org/1910253005
    Cr-Commit-Position: refs/heads/master@{#35833}

Fixes: #9288
PR-URL: #9293
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
    @bnoordhuis
    bnoordhuis committed Mar 2, 2017
    Configuration menu
    Copy the full SHA
    a38d091 View commit details
    Browse the repository at this point in the history

  3. deps: back-port 73ee7943 from v8 upstream 

    Original commit message:

    When instantiating a subclassed API function, the instance cache
    is avoided. There is currently no direct API yet to instantiate
    a Template while passing in a new.target. It probably makes sense
    to extend ObjectTemplate::NewInstance to accept a new.target, in
    line with Reflect.construct.

    BUG=v8:3330, v8:5001

    Review-Url: https://codereview.chromium.org/1972613002
    Cr-Commit-Position: refs/heads/master@{#36179}

Fixes: #9288
PR-URL: #9293
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
    @bnoordhuis
    bnoordhuis committed Mar 2, 2017
    Configuration menu
    Copy the full SHA
    0eb4f1d View commit details
    Browse the repository at this point in the history

  4. v8: drop v8::FunctionCallbackInfo<T>::NewTarget() 

    Remove the new method that was introduced in the back-port of
v8/v8@306c412c ("[api] Expose FunctionCallbackInfo::NewTarget")
so that the meat of the patch can land in a patch release.

This commit can be reverted again in the next minor release.

Fixes: #9288
PR-URL: #9293
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
    @bnoordhuis
    bnoordhuis committed Mar 2, 2017
    Configuration menu
    Copy the full SHA
    47cbb88 View commit details
    Browse the repository at this point in the history

  5. test: add new.target add-on regression test 

    Add a test that checks that new.target inheritance works when inheriting
from a constructor defined in C++.

PR-URL: #9689
Refs: #9288
Refs: #9293
Reviewed-By: Anna Henningsen <anna@addaleax.net>
    @bnoordhuis
    bnoordhuis committed Mar 2, 2017
    Configuration menu
    Copy the full SHA
    2ebceed View commit details
    Browse the repository at this point in the history
Loading