Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 16ef09fc491b7a3e9bc07a290567859ca6f90539
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 057731285286f6ba6f3db765f3986d93809912ea
Choose a head ref
  • 3 commits
  • 4 files changed
  • 2 contributors

Commits on Jun 6, 2018

  1. lib: add validateInteger() validator 

    This allows validation of integers that are not int32 or uint32.

PR-URL: #20851
Fixes: #20844
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

Backport-PR-URL: #21171
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
    @cjihrig @codebytere @targos
    2 people authored and targos committed Jun 6, 2018
    Configuration menu
    Copy the full SHA
    e94231e View commit details
    Browse the repository at this point in the history

  2. fs: add length validation to fs.truncate() 

    This commit adds validation to the length parameter of
fs.truncate(). Prior to this commit, passing a non-number would
trigger a CHECK() in the binding layer.

Backport-PR-URL: #21171
PR-URL: #20851
Fixes: #20844
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

Backport-PR-URL: #21171
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
    @cjihrig @codebytere @targos
    2 people authored and targos committed Jun 6, 2018
    Configuration menu
    Copy the full SHA
    56e5336 View commit details
    Browse the repository at this point in the history

  3. fs: don't limit ftruncate() length to 32 bits 

    The length used by ftruncate() is 64 bits in the binding layer.
This commit removes the 32 bit restriction in the JS layer.

Backport-PR-URL: #21171
PR-URL: #20851
Fixes: #20844
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

Backport-PR-URL: #21171
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
    @cjihrig @codebytere @targos
    2 people authored and targos committed Jun 6, 2018
    Configuration menu
    Copy the full SHA
    0577312 View commit details
    Browse the repository at this point in the history
Loading