Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 144f876c6872ece2da5c87a41266d14a2f49273f
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: f11e8b959dce355bbb21fa2f95108732db464897
Choose a head ref
  • 2 commits
  • 22 files changed
  • 1 contributor

Commits on Mar 2, 2019

  1. tools: use latest rather than next for markdown linting plugin 

    eslint-plugin-markdown is being installed @next to get a bugfix for
eslint/markdown#69 but that
bugfix is in 1.0.0. Go back to installing @latest rather than @next.

PR-URL: #26345
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    @Trott
    Trott committed Mar 2, 2019
    Configuration menu
    Copy the full SHA
    e0c3921 View commit details
    Browse the repository at this point in the history

  2. tools: update eslint-plugin-markdown to 1.0.0 

    For eslint-plugin-markdown, we had been using an RC but can now use the
most recent stable release of 1.0.0, as it has the bugfix that caused us
to start using the RC in the first place.

There are a few other updates in this commit too because it was
performed by running `update-eslint.sh`. This did not update ESLint
itself but did update some dependencies.

PR-URL: #26345
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    @Trott
    Trott committed Mar 2, 2019
    Configuration menu
    Copy the full SHA
    f11e8b9 View commit details
    Browse the repository at this point in the history
Loading