Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0d9500daedbb61770359c34383a8d4784bcabd56
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: f9de6f580460d01309b5d9e4d980ed37624de1a9
Choose a head ref
  • 2 commits
  • 14 files changed
  • 1 contributor

Commits on May 17, 2018

  1. lib: mask mode_t type of arguments with 0o777 

    - Introduce the `validateAndMaskMode` validator that
  validates `mode_t` arguments and mask them with 0o777
  if they are 32-bit unsigned integer or octal string
  to be more consistent with POSIX APIs.
- Use the validator in fs APIs and process.umask for
  consistency.
- Add tests for 32-bit unsigned modes larger than 0o777.

PR-URL: #20636
Fixes: #20498
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    @joyeecheung
    joyeecheung committed May 17, 2018
    Configuration menu
    Copy the full SHA
    a18e130 View commit details
    Browse the repository at this point in the history

  2. doc: document file mode caveats on Windows 

    - On Windows only the write permission (read-only bit) can be
  manipulated, and there is no distinction among owner, group
  or others.
- mkdir on Windows does not support the mode argument.

PR-URL: #20636
Fixes: #20498
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    @joyeecheung
    joyeecheung committed May 17, 2018
    Configuration menu
    Copy the full SHA
    f9de6f5 View commit details
    Browse the repository at this point in the history
Loading