Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 04ae4862e670a8849454e6d8db4d8f73d0492190
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 805dca199aff69edc1b3ead82365182ad0bf651d
Choose a head ref
  • 10 commits
  • 10 files changed
  • 1 contributor

Commits on Dec 13, 2017

  1. fs: move type checking for fs.close to js 

    PR-URL: #17334
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    @jasnell
    jasnell committed Dec 13, 2017
    Configuration menu
    Copy the full SHA
    8974df1 View commit details
    Browse the repository at this point in the history

  2. fs: move type checking on fs.fstat to js 

    PR-URL: #17334
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    @jasnell
    jasnell committed Dec 13, 2017
    Configuration menu
    Copy the full SHA
    6390968 View commit details
    Browse the repository at this point in the history

  3. fs: move type checking for fs.fdatasync to js 

    PR-URL: #17334
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    @jasnell
    jasnell committed Dec 13, 2017
    Configuration menu
    Copy the full SHA
    956f97b View commit details
    Browse the repository at this point in the history

  4. fs: move type checking for fs.sync to js 

    PR-URL: #17334
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    @jasnell
    jasnell committed Dec 13, 2017
    Configuration menu
    Copy the full SHA
    8cb080c View commit details
    Browse the repository at this point in the history

  5. fs: move type checking for fs.ftruncate to js 

    PR-URL: #17334
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    @jasnell
    jasnell committed Dec 13, 2017
    Configuration menu
    Copy the full SHA
    d453fac View commit details
    Browse the repository at this point in the history

  6. fs: move type checking for fs.fchmod to js 

    PR-URL: #17334
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    @jasnell
    jasnell committed Dec 13, 2017
    Configuration menu
    Copy the full SHA
    0a01aa8 View commit details
    Browse the repository at this point in the history

  7. fs: move type checking for fs.fchown to js 

    PR-URL: #17334
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    @jasnell
    jasnell committed Dec 13, 2017
    Configuration menu
    Copy the full SHA
    82eb459 View commit details
    Browse the repository at this point in the history

  8. fs: move type checking in fs.futimes to js 

    PR-URL: #17334
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    @jasnell
    jasnell committed Dec 13, 2017
    Configuration menu
    Copy the full SHA
    448ec0b View commit details
    Browse the repository at this point in the history

  9. fs: move type checking for fs.read to js 

    PR-URL: #17334
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    @jasnell
    jasnell committed Dec 13, 2017
    Configuration menu
    Copy the full SHA
    1638698 View commit details
    Browse the repository at this point in the history

  10. fs: remove unnecessary throw on fs.mkdtemp 

    The type is already checked in JS. Change to a CHECK

PR-URL: #17334
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    @jasnell
    jasnell committed Dec 13, 2017
    Configuration menu
    Copy the full SHA
    805dca1 View commit details
    Browse the repository at this point in the history
Loading