Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0301309493b2a4e80796517bdb46ec55202a4800
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: b8a2550ec0a7fd6ce1f9a6b6b7cf2bfbf96fb484
Choose a head ref
  • 3 commits
  • 9 files changed
  • 1 contributor

Commits on Aug 12, 2024

  1. sqlite: ensure statement finalization on db close 

    This commit adds statement tracking to the DatabaseSync class.
When a database is closed manually or via garbage collection, it
will force all associated prepared statements to be finalized.
This should mitigate "zombie" connections which can introduce
test flakiness in the CI on Windows.

PR-URL: #54014
Fixes: #54006
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
    @cjihrig @nodejs-github-bot
    cjihrig authored and nodejs-github-bot committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    717b401 View commit details
    Browse the repository at this point in the history

  2. sqlite: split up large test file 

    The original test/parallel/test-sqlite.js test appears to time
out in the CI occasionally. This commit splits the test into
several smaller test files.

Fixes: #54006
PR-URL: #54014
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
    @cjihrig @nodejs-github-bot
    cjihrig authored and nodejs-github-bot committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    916865b View commit details
    Browse the repository at this point in the history

  3. test: unmark test-sqlite as flaky 

    PR-URL: #54014
Fixes: #54006
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
    @cjihrig @nodejs-github-bot
    cjihrig authored and nodejs-github-bot committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    b8a2550 View commit details
    Browse the repository at this point in the history
Loading