Skip to content

Commit dbdcf12

Browse files
cjihrigcjihrig
committed
doc: correct buffer changelog ordering
This commit reorders the function level changelogs of Buffer.prototype.fill() and Buffer.alloc() to reflect the order in which the entries were added. PR-URL: #18129 Fixes: #18128 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
1 parent 1e80253 commit dbdcf12

1 file changed

Lines changed: 15 additions & 15 deletions

File tree

‎doc/api/buffer.md‎

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -511,18 +511,18 @@ console.log(buf2.toString());
511511
<!-- YAML
512512
added: v5.10.0
513513
changes:
514-
- version: v8.9.3
515-
pr-url: https://github.com/nodejs/node/pull/17428
516-
description: Specifying an invalid string for `fill` now results in a
517-
zero-filled buffer.
518-
- version: REPLACEME
519-
pr-url: https://github.com/nodejs/node/pull/17427
520-
description: Specifying an invalid string for `fill` triggers a thrown
521-
exception.
522514
- version: REPLACEME
523515
pr-url: https://github.com/nodejs/node/pull/18129
524516
description: Attempting to fill a non-zero length buffer with a zero length
525517
buffer triggers a thrown exception.
518+
- version: REPLACEME
519+
pr-url: https://github.com/nodejs/node/pull/17427
520+
description: Specifying an invalid string for `fill` triggers a thrown
521+
exception.
522+
- version: v8.9.3
523+
pr-url: https://github.com/nodejs/node/pull/17428
524+
description: Specifying an invalid string for `fill` now results in a
525+
zero-filled buffer.
526526
-->
527527

528528
* `size` {integer} The desired length of the new `Buffer`.
@@ -1228,17 +1228,17 @@ console.log(buf1.equals(buf3));
12281228
<!-- YAML
12291229
added: v0.5.0
12301230
changes:
1231-
- version: v5.7.0
1232-
pr-url: https://github.com/nodejs/node/pull/4935
1233-
description: The `encoding` parameter is supported now.
1234-
- version: REPLACEME
1235-
pr-url: https://github.com/nodejs/node/pull/17427
1236-
description: Specifying an invalid string for `value` triggers a thrown
1237-
exception.
12381231
- version: REPLACEME
12391232
pr-url: https://github.com/nodejs/node/pull/18129
12401233
description: Attempting to fill a non-zero length buffer with a zero length
12411234
buffer triggers a thrown exception.
1235+
- version: REPLACEME
1236+
pr-url: https://github.com/nodejs/node/pull/17427
1237+
description: Specifying an invalid string for `value` triggers a thrown
1238+
exception.
1239+
- version: v5.7.0
1240+
pr-url: https://github.com/nodejs/node/pull/4935
1241+
description: The `encoding` parameter is supported now.
12421242
-->
12431243

12441244
* `value` {string|Buffer|integer} The value to fill `buf` with.

0 commit comments

Comments
 (0)