Skip to content

Commit bcae997

Browse files
committed
sqlite: use cached strings for property keys
Signed-off-by: Kyungrae Kang <kyungrae2002@gmail.com> Assisted-by: Codex
1 parent 66f26d3 commit bcae997

1 file changed

Lines changed: 6 additions & 18 deletions

File tree

‎src/node_sqlite.cc‎

Lines changed: 6 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -2171,9 +2171,7 @@ void Database::Prepare(const FunctionCallbackInfo<Value>& args) {
21712171
Local<Object> options = args[1].As<Object>();
21722172

21732173
Local<Value> return_arrays_v;
2174-
if (!options
2175-
->Get(env->context(),
2176-
FIXED_ONE_BYTE_STRING(env->isolate(), "returnArrays"))
2174+
if (!options->Get(env->context(), env->return_arrays_string())
21772175
.ToLocal(&return_arrays_v)) {
21782176
return;
21792177
}
@@ -2188,9 +2186,7 @@ void Database::Prepare(const FunctionCallbackInfo<Value>& args) {
21882186
}
21892187

21902188
Local<Value> read_big_ints_v;
2191-
if (!options
2192-
->Get(env->context(),
2193-
FIXED_ONE_BYTE_STRING(env->isolate(), "readBigInts"))
2189+
if (!options->Get(env->context(), env->read_bigints_string())
21942190
.ToLocal(&read_big_ints_v)) {
21952191
return;
21962192
}
@@ -2205,10 +2201,7 @@ void Database::Prepare(const FunctionCallbackInfo<Value>& args) {
22052201
}
22062202

22072203
Local<Value> allow_bare_named_params_v;
2208-
if (!options
2209-
->Get(env->context(),
2210-
FIXED_ONE_BYTE_STRING(env->isolate(),
2211-
"allowBareNamedParameters"))
2204+
if (!options->Get(env->context(), env->allow_bare_named_params_string())
22122205
.ToLocal(&allow_bare_named_params_v)) {
22132206
return;
22142207
}
@@ -2224,10 +2217,7 @@ void Database::Prepare(const FunctionCallbackInfo<Value>& args) {
22242217
}
22252218

22262219
Local<Value> allow_unknown_named_params_v;
2227-
if (!options
2228-
->Get(env->context(),
2229-
FIXED_ONE_BYTE_STRING(env->isolate(),
2230-
"allowUnknownNamedParameters"))
2220+
if (!options->Get(env->context(), env->allow_unknown_named_params_string())
22312221
.ToLocal(&allow_unknown_named_params_v)) {
22322222
return;
22332223
}
@@ -5338,10 +5328,8 @@ static void Initialize(Local<Object> target,
53385328
db_tmpl,
53395329
FIXED_ONE_BYTE_STRING(isolate, "isTransaction"),
53405330
Database::IsTransactionGetter);
5341-
SetSideEffectFreeGetter(isolate,
5342-
db_tmpl,
5343-
FIXED_ONE_BYTE_STRING(isolate, "limits"),
5344-
Database::LimitsGetter);
5331+
SetSideEffectFreeGetter(
5332+
isolate, db_tmpl, env->limits_string(), Database::LimitsGetter);
53455333
Local<String> sqlite_type_key = FIXED_ONE_BYTE_STRING(isolate, "sqlite-type");
53465334
Local<v8::Symbol> sqlite_type_symbol =
53475335
v8::Symbol::For(isolate, sqlite_type_key);

0 commit comments

Comments
 (0)