Skip to content

Commit b534fc9

Browse files
panvapanva
committed
crypto: avoid EC reconstruction for signature sizing
Use EVP_PKEY_bits() to determine the width of ECDSA signature components on OpenSSL 3. This avoids reconstructing the EC group and public point just to read the group order size. Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: GitHub Copilot
1 parent 0ddf3c9 commit b534fc9

1 file changed

Lines changed: 1 addition & 5 deletions

File tree

‎deps/ncrypto/ncrypto.cc‎

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4147,11 +4147,7 @@ std::optional<uint32_t> EVPKeyPointer::getBytesOfRS() const {
41474147
#endif
41484148
} else if (id == EVP_PKEY_EC) {
41494149
#if NCRYPTO_USE_OPENSSL3_PROVIDER
4150-
Ec ec(get());
4151-
if (!ec) return std::nullopt;
4152-
const EC_GROUP* group = ec.getGroup();
4153-
if (group == nullptr) return std::nullopt;
4154-
bits = EC_GROUP_order_bits(group);
4150+
bits = EVP_PKEY_bits(get());
41554151
#else
41564152
const EC_KEY* ec_key = EVP_PKEY_get0_EC_KEY(get());
41574153
if (ec_key == nullptr) return std::nullopt;

0 commit comments

Comments
 (0)