Skip to content

Commit 1ab2db6

Browse files
nektronektro
committed
lib: fix default AbortController.abort() message
did not previously match spec https://dom.spec.whatwg.org/#dom-abortsignal-abort https://webidl.spec.whatwg.org/#aborterror Co-authored-by: pfg <pfg@pfg.pw>
1 parent 5a2614f commit 1ab2db6

5 files changed

Lines changed: 21 additions & 21 deletions

File tree

‎lib/internal/abort_controller.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ class AbortSignal extends EventTarget {
227227
* @returns {AbortSignal}
228228
*/
229229
static abort(
230-
reason = new DOMException('This operation was aborted', 'AbortError')) {
230+
reason = new DOMException('This operation was aborted.', 'AbortError')) {
231231
return new AbortSignal(kDontThrowSymbol, { aborted: true, reason });
232232
}
233233

@@ -464,7 +464,7 @@ class AbortController {
464464
/**
465465
* @param {any} [reason]
466466
*/
467-
abort(reason = new DOMException('This operation was aborted', 'AbortError')) {
467+
abort(reason = new DOMException('This operation was aborted.', 'AbortError')) {
468468
abortSignal(this.#signal ??= new AbortSignal(kDontThrowSymbol), reason);
469469
}
470470

‎test/fixtures/test-runner/output/abort.snapshot‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ TAP version 13
5151
type: 'test'
5252
location: '/test/fixtures/test-runner/output/abort.js:(LINE):7'
5353
failureType: 'testAborted'
54-
error: 'This operation was aborted'
54+
error: 'This operation was aborted.'
5555
code: 20
5656
name: 'AbortError'
5757
stack: |-
@@ -73,7 +73,7 @@ TAP version 13
7373
type: 'test'
7474
location: '/test/fixtures/test-runner/output/abort.js:(LINE):7'
7575
failureType: 'testAborted'
76-
error: 'This operation was aborted'
76+
error: 'This operation was aborted.'
7777
code: 20
7878
name: 'AbortError'
7979
stack: |-
@@ -95,7 +95,7 @@ TAP version 13
9595
type: 'test'
9696
location: '/test/fixtures/test-runner/output/abort.js:(LINE):7'
9797
failureType: 'testAborted'
98-
error: 'This operation was aborted'
98+
error: 'This operation was aborted.'
9999
code: 20
100100
name: 'AbortError'
101101
stack: |-
@@ -133,7 +133,7 @@ not ok 2 - promise abort signal
133133
type: 'test'
134134
location: '/test/fixtures/test-runner/output/abort.js:(LINE):1'
135135
failureType: 'testAborted'
136-
error: 'This operation was aborted'
136+
error: 'This operation was aborted.'
137137
code: 20
138138
name: 'AbortError'
139139
stack: |-
@@ -200,7 +200,7 @@ not ok 2 - promise abort signal
200200
type: 'test'
201201
location: '/test/fixtures/test-runner/output/abort.js:(LINE):5'
202202
failureType: 'testAborted'
203-
error: 'This operation was aborted'
203+
error: 'This operation was aborted.'
204204
code: 20
205205
name: 'AbortError'
206206
stack: |-
@@ -222,7 +222,7 @@ not ok 2 - promise abort signal
222222
type: 'test'
223223
location: '/test/fixtures/test-runner/output/abort.js:(LINE):5'
224224
failureType: 'testAborted'
225-
error: 'This operation was aborted'
225+
error: 'This operation was aborted.'
226226
code: 20
227227
name: 'AbortError'
228228
stack: |-
@@ -244,7 +244,7 @@ not ok 2 - promise abort signal
244244
type: 'test'
245245
location: '/test/fixtures/test-runner/output/abort.js:(LINE):5'
246246
failureType: 'testAborted'
247-
error: 'This operation was aborted'
247+
error: 'This operation was aborted.'
248248
code: 20
249249
name: 'AbortError'
250250
stack: |-
@@ -282,7 +282,7 @@ not ok 4 - callback abort signal
282282
type: 'test'
283283
location: '/test/fixtures/test-runner/output/abort.js:(LINE):1'
284284
failureType: 'testAborted'
285-
error: 'This operation was aborted'
285+
error: 'This operation was aborted.'
286286
code: 20
287287
name: 'AbortError'
288288
stack: |-

‎test/fixtures/test-runner/output/abort_hooks.snapshot‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ not ok 1 - 1 before describe
3535
type: 'suite'
3636
location: '/test/fixtures/test-runner/output/abort_hooks.js:(LINE):1'
3737
failureType: 'hookFailed'
38-
error: 'This operation was aborted'
38+
error: 'This operation was aborted.'
3939
code: 20
4040
name: 'AbortError'
4141
stack: |-
@@ -70,7 +70,7 @@ not ok 2 - 2 after describe
7070
type: 'suite'
7171
location: '/test/fixtures/test-runner/output/abort_hooks.js:(LINE):1'
7272
failureType: 'hookFailed'
73-
error: 'This operation was aborted'
73+
error: 'This operation was aborted.'
7474
code: 20
7575
name: 'AbortError'
7676
stack: |-
@@ -93,7 +93,7 @@ not ok 2 - 2 after describe
9393
type: 'test'
9494
location: '/test/fixtures/test-runner/output/abort_hooks.js:(LINE):3'
9595
failureType: 'hookFailed'
96-
error: 'This operation was aborted'
96+
error: 'This operation was aborted.'
9797
code: 20
9898
name: 'AbortError'
9999
stack: |-
@@ -115,7 +115,7 @@ not ok 2 - 2 after describe
115115
type: 'test'
116116
location: '/test/fixtures/test-runner/output/abort_hooks.js:(LINE):3'
117117
failureType: 'hookFailed'
118-
error: 'This operation was aborted'
118+
error: 'This operation was aborted.'
119119
code: 20
120120
name: 'AbortError'
121121
stack: |-
@@ -148,7 +148,7 @@ not ok 3 - 3 beforeEach describe
148148
type: 'test'
149149
location: '/test/fixtures/test-runner/output/abort_hooks.js:(LINE):3'
150150
failureType: 'hookFailed'
151-
error: 'This operation was aborted'
151+
error: 'This operation was aborted.'
152152
code: 20
153153
name: 'AbortError'
154154
stack: |-
@@ -170,7 +170,7 @@ not ok 3 - 3 beforeEach describe
170170
type: 'test'
171171
location: '/test/fixtures/test-runner/output/abort_hooks.js:(LINE):3'
172172
failureType: 'hookFailed'
173-
error: 'This operation was aborted'
173+
error: 'This operation was aborted.'
174174
code: 20
175175
name: 'AbortError'
176176
stack: |-

‎test/fixtures/test-runner/output/abort_suite.snapshot‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ TAP version 13
5151
type: 'test'
5252
location: '/test/fixtures/test-runner/output/abort_suite.js:(LINE):3'
5353
failureType: 'testAborted'
54-
error: 'This operation was aborted'
54+
error: 'This operation was aborted.'
5555
code: 20
5656
name: 'AbortError'
5757
stack: |-
@@ -73,7 +73,7 @@ TAP version 13
7373
type: 'test'
7474
location: '/test/fixtures/test-runner/output/abort_suite.js:(LINE):3'
7575
failureType: 'testAborted'
76-
error: 'This operation was aborted'
76+
error: 'This operation was aborted.'
7777
code: 20
7878
name: 'AbortError'
7979
stack: |-
@@ -95,7 +95,7 @@ TAP version 13
9595
type: 'test'
9696
location: '/test/fixtures/test-runner/output/abort_suite.js:(LINE):3'
9797
failureType: 'testAborted'
98-
error: 'This operation was aborted'
98+
error: 'This operation was aborted.'
9999
code: 20
100100
name: 'AbortError'
101101
stack: |-
@@ -133,7 +133,7 @@ not ok 2 - describe abort signal
133133
type: 'suite'
134134
location: '/test/fixtures/test-runner/output/abort_suite.js:(LINE):1'
135135
failureType: 'testAborted'
136-
error: 'This operation was aborted'
136+
error: 'This operation was aborted.'
137137
code: 20
138138
name: 'AbortError'
139139
stack: |-

‎test/parallel/test-child-process-exec-abortcontroller-promisified.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ const waitCommand = common.isWindows ?
2121
const promise = execPromisifed(waitCommand, { signal });
2222
assert.rejects(promise, {
2323
name: 'AbortError',
24-
cause: new DOMException('This operation was aborted', 'AbortError'),
24+
cause: new DOMException('This operation was aborted.', 'AbortError'),
2525
}).then(common.mustCall());
2626
ac.abort();
2727
}

0 commit comments

Comments
 (0)