Repository navigation
update clang on FreeBSD 10 #723
Description
Ref: nodejs/node-v8#1
Latest V8 cannot be compiled with version 3.4.1. We should try to update to 3.4.2 and see if that fixes the crash.
/cc @jbergstroem
Ref: nodejs/node-v8#1
Latest V8 cannot be compiled with version 3.4.1. We should try to update to 3.4.2 and see if that fixes the crash.
/cc @jbergstroem
Activity
jbergstroem commentedon May 16, 2017
Ok, I will open a PR tomorrow.
targos commentedon May 25, 2017
ping
jbergstroem commentedon May 26, 2017
Truly sorry :( $wrk, etc etc. I will get to it as soon as I can; likely tomorrow morning.
targos commentedon Jun 13, 2017
ping @nodejs/build (no worries @jbergstroem. I totally understand that you can be busy)
Trott commentedon Jun 20, 2017
@gibfahn Did you mean to add the
wg-agendalabel or isctc-agendacorrect? Ifctc-agenda, can you (or someone else) provide a short description of what you hope CTC will do? Thanks!joaocgreis commentedon Jun 20, 2017
Was
wg-agendaand was already discussed in #766kfarnung commentedon Jun 26, 2017
I'm going to be taking a look at it this week.
kfarnung commentedon Jun 27, 2017
@targos I've taken a look at this and it's not too straightforward. I have opened #772 for the first step, installing the
clang34package, but there's a bit more subtlety to the builds on FreeBSD. I'll keep working on this throughout the week.As a side note, are the builds still failing with 3.4.1? I don't see any indication of the original build issue in the CI or in my local builds.
targos commentedon Jun 27, 2017
@kfarnung Thank you for looking into this.
The builds are failing with V8 6.0. You can try to reproduce with this branch: https://github.com/targos/node/tree/v8-6.0
The latest failure on CI is here: https://ci.nodejs.org/job/node-test-commit-freebsd/9863/nodes=freebsd10-64/console
kfarnung commentedon Jun 27, 2017
Thanks @targos, that was the key. I'm now able to repro the crash. Unfortunately I'm still seeing the crash on 3.4.2, see attached, so I'm going to try 3.5 (EDIT: also failing) and 3.8 (EDIT: passing) as well, just to see if any of the newer versions resolve the issue.
Attempts
kfarnung commentedon Jun 27, 2017
@jbergstroem Is there any objection to upgrading clang to 3.8.1? That's approximately the same version as FreeBSD 11 (which uses 3.8.0).
jbergstroem commentedon Jun 28, 2017
@kfarnung I will have a chat with package maintainers in FreeBSD seeing how they should/would run into this as well.
jbergstroem commentedon Jun 29, 2017
I've emailed with @bradleythughes (one of the node maintainers in ports/freebsd) about this and their build system can reproduce the same issues. The idea is to spend a bit of time seeing how feasible it is to fix this upstream (v8).
In general, is the v8 team moving forward with raising the lowest required clang version? @targos do you perhaps know?
7 remaining items
kfarnung commentedon Jul 21, 2017
If we want to stay with current OS packages then it's 3.8.1 (which is slightly ahead of the FreeBSD 11 machine which uses 3.8.0).
gibfahn commentedon Jul 22, 2017
3.8.1 SGTM
jbergstroem commentedon Jul 22, 2017
Ok, I can do the PR.
kfarnung commentedon Jul 22, 2017
You can base it on #772
MylesBorins commentedon Jul 25, 2017
@targos I dug in a little bit more and it would appear the biggest change (aside from the giant refactor) was making
AsyncCompileJob::CompileTaskno longer a template class. I'm thinking that the bug in Clang is related to thisMylesBorins commentedon Jul 25, 2017
I think I have a fix
MylesBorins/node@70b4ec5
bnoordhuis commentedon Jul 26, 2017
@MylesBorins We updated the baseline to clang 3.4.2 for precisely the reason you describe in the commit log.
build: move FreeBSD to experimental
MylesBorins commentedon Jul 26, 2017
ignisf commentedon Aug 23, 2017
@MylesBorins could you please link to your change in upstream V8?
ignisf commentedon Aug 23, 2017
Ah, nvm, found it https://chromium-review.googlesource.com/c/v8/v8/+/585979
targos commentedon Sep 19, 2017
I suppose this can be closed for now.