Skip to content

Builds failing on test-azure_msft-win10_vs2019-x64-4 #2526

Closed

Description

@richardlau

Jobs on test-azure_msft-win10_vs2019-x64-4 are consistently failing:

e.g. https://ci.nodejs.org/job/node-test-binary-windows-js-suites/RUN_SUBSET=3,nodes=win10-COMPILED_BY-vs2017/7816/console

11:43:17 > git clean -dffx 
11:43:17 warning: failed to remove test/.tmp.520UN9cn6/middle: Permission denied
11:43:17 
11:43:17 > if errorlevel 1 exit /b 
11:43:17 
11:43:17 > if errorlevel 1 exit /b 
11:43:17 
11:43:17 > if errorlevel 1 exit /b 
11:43:17 
11:43:17 > if errorlevel 1 exit /b 
11:43:17 Build step 'Execute Windows batch command' marked build as failure

Looking at build history, jobs were generally passing until https://ci.nodejs.org/job/node-test-binary-windows-js-suites/RUN_SUBSET=3,nodes=win10-COMPILED_BY-vs2019/7798/console which had this test failure:

14:27:26 not ok 520 parallel/test-rmdirSync-busy-loop-windows
14:27:26   ---
14:27:26   duration_ms: 0.167
14:27:26   severity: fail
14:27:26   exitcode: 1
14:27:26   stack: |-
14:27:26     node:assert:119
14:27:26       throw new AssertionError(obj);
14:27:26       ^
14:27:26     
14:27:26     AssertionError [ERR_ASSERTION]: Missing expected exception.
14:27:26         at Object.<anonymous> (C:\workspace\node-test-binary-windows-js-suites\node\test\parallel\test-rmdirSync-busy-loop-windows.js:25:8)
14:27:26         at Module._compile (node:internal/modules/cjs/loader:1108:14)
14:27:26         at Object.Module._extensions..js (node:internal/modules/cjs/loader:1137:10)
14:27:26         at Module.load (node:internal/modules/cjs/loader:973:32)
14:27:26         at Function.Module._load (node:internal/modules/cjs/loader:813:14)
14:27:26         at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:76:12)
14:27:26         at node:internal/main/run_main_module:17:47 {
14:27:26       generatedMessage: false,
14:27:26       code: 'ERR_ASSERTION',
14:27:26       actual: undefined,
14:27:26       expected: /EACCES/,
14:27:26       operator: 'throws'
14:27:26     }
14:27:26   ...

After that build every build on the machine has failed with the permission denied warning.

parallel/test-rmdirSync-busy-loop-windows is a new test being added by nodejs/node#36815 and it looks like this test is intentionally stripping permissions from the middle dir:

  const middle = join(root, 'middle');
  fs.mkdirSync(middle);
  fs.mkdirSync(join(middle, 'leaf')); // Make `middle` non-empty
  fs.chmodSync(middle, 0);

Activity

  1. richardlau commented on Jan 21, 2021

    @richardlau
    MemberAuthor

    Tried to wipe out the workspace but that failed with an AccessDeniedException on the same dir:

    Jan 21, 2021 7:35:38 AM WARNING org.eclipse.jetty.server.handler.ContextHandler$Context log
    Error while serving https://ci.nodejs.org/job/node-test-binary-windows-js-suites/RUN_SUBSET=3,nodes=win10-COMPILED_BY-vs2017/doWipeOutWorkspace
    Also:   	Also:   java.nio.file.AccessDeniedException: C:\workspace\node-test-binary-windows-js-suites\node\test\.tmp.520UN9cn6\middle
    

    I don't think rebooting (https://ci.nodejs.org/job/windows-update-reboot/) this host will help, so I'll mark it offline in Jenkins for the moment.
    cc @joaocgreis

  2. richardlau commented on Jan 21, 2021

    @richardlau
    MemberAuthor

    Looks like the new CI run for nodejs/node#36815 has caused the issue to pop up on https://ci.nodejs.org/computer/test-azure_msft-win10_vs2019-x64-1/

    https://ci.nodejs.org/job/node-test-binary-windows-js-suites/RUN_SUBSET=0,nodes=win10-COMPILED_BY-vs2017/7819/console

    16:11:11 > git clean -dffx 
    16:11:11 warning: failed to remove test/.tmp.520LWo1gw/middle: Permission denied
    16:11:11 
    16:11:11 > if errorlevel 1 exit /b 
    16:11:11 
    16:11:11 > if errorlevel 1 exit /b 
    16:11:11 
    16:11:11 > if errorlevel 1 exit /b 
    16:11:11 
    16:11:11 > if errorlevel 1 exit /b 
    16:11:11 Build step 'Execute Windows batch command' marked build as failure
    

    via the test failure in https://ci.nodejs.org/job/node-test-binary-windows-js-suites/7818/RUN_SUBSET=3,nodes=win10-COMPILED_BY-vs2019/.

    The test also failed in https://ci.nodejs.org/job/node-test-binary-windows-js-suites/7818/RUN_SUBSET=3,nodes=win2012r2-COMPILED_BY-vs2019-x86/ so https://ci.nodejs.org/computer/test-rackspace-win2012r2_vs2019-x64-2/ may also be affected now.

  3. richardlau commented on Jan 21, 2021

    @richardlau
    MemberAuthor
  4. richardlau commented on Jan 21, 2021

    @richardlau
    MemberAuthor

    Reading https://github.com/nodejs/build/blob/master/doc/jenkins-guide.md#windows and the job config for https://ci.nodejs.org/view/All/job/git-clean-windows/ we may be able to fix by running the git-clean-windows script (which moves away the workspace instead of deleting:

    # Move instead of deleting directly because sometimes it is not possible to delete (NFS issues).
    cd ..
    mkdir $TMP_DIR
    time mv -v node-* $TMP_DIR || true
    

    I suspect we'll still be left with the renamed workspaces on the machine(s).

  5. richardlau commented on Jan 21, 2021

    @richardlau
    MemberAuthor

    Ran https://ci.nodejs.org/view/All/job/git-clean-windows/194/ and this appears to have fixed https://ci.nodejs.org/computer/test-azure_msft-win10_vs2019-x64-4/:
    image

    I suspect we'll still be left with the renamed workspaces on the machine(s).

    Looks like that might not be the case 😀:
    https://ci.nodejs.org/job/git-clean-windows/label=test-azure_msft-win10_vs2019-x64-4/194/consoleFull

    removed directory 'delete_1611246846/node-test-binary-windows-js-suites/node/test/.tmp.520UN9cn6/middle'
    removed directory 'delete_1611246846/node-test-binary-windows-js-suites/node/test/.tmp.520UN9cn6'
    
  6. richardlau commented on Jan 21, 2021

    @richardlau
    MemberAuthor

    Fixed by running https://ci.nodejs.org/view/All/job/git-clean-windows/.

    Underlying issue in nodejs/node#36815 remains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions