Repository navigation
Objection Override -> [#33879](https://github.com/nodejs/node/pull/33879) #928
Description
We discussed this in the TSC meeting this week.
Proposal is to override the objection after the PR having been updated to reflect this suggested compromise:
- Reduce the current time limits to 24 hours with two sign offs, at least one of which is from relevant CODEOWNERS team, or 72 hours with one sign off.
Along with a planned audit of the current members of the CODEOWNERS for each area.
@nodejs/tsc unless there are objections by Wed Sep 23rd, the assumption will be that TSC consensus on this as the direction has been reached.
Activity
mmarchini commentedon Sep 17, 2020
If there are more than one codeowner for a PR, will one approval from each team be require, or only from one of the teams?
MylesBorins commentedon Sep 17, 2020
I was under the impression it was one member from one of the teams, although I think this does beg the question of in what circumstance there will be more than one codeowner, and how those specific teams feel about it
mmarchini commentedon Sep 17, 2020
A PR touching two subsystems would be one case where more than one team is pinged. Another question: the approval still has to be from a collaborator (since codeowners can be working group teams and not all members will be collaborators), right?
mmarchini commentedon Sep 17, 2020
As for audit, how far do we want to go with the strictness of it? I think we could have an Action in this repository that runs periodically and dumps membership of all teams in the org into files, and opens a PR if anything changes. This way we get notified of any membership changes. It's not super robust since the Action would need to run periodically instead of on an event (there are no Actions for Org events yet), but better than nothing I guess? Or is this more than necessary, and just a sweep of teams every once in a while is enough?
mmarchini commentedon Sep 17, 2020
Plus, should we aim for 100% codeownership on nodejs/node?
mmarchini commentedon Sep 17, 2020
(I'm plus one on this proposal, just want to make sure we remove some ambiguity or unclarity from it)
ljharb commentedon Sep 17, 2020
Linking to nodejs/node#33879
mhdawson commentedon Sep 18, 2020
Also related discussion in #921
mhdawson commentedon Sep 24, 2020
@mmarchini I was looking to see if we have consensus as the target we set for objections has passed. I'm not sure if you think we should change the proposal to be put into nodejs/node#33879 or if the details of the audit can be finalised agreed afterwards?
mmarchini commentedon Oct 2, 2020
Audit can be done afterwards IMO
mmarchini commentedon Oct 2, 2020
There were no objections, so I'll assume this is approved. I'll leave a comment in the PR and remove from the agenda.