Skip to content

Backport WHATWG URL to 6.x? #208

Closed
Closed

Description

@jasnell

Now that the WHATWG URL implementation is close to graduating from Experimental status, I would like to open a discussion about whether it makes sense to backport the implementation to 6.x..

/cc @targos @TimothyGu @watilde @joyeecheung @nodejs/lts

Activity

  1. TimothyGu commented on Apr 28, 2017

    @TimothyGu
    Member

    New features don't seem to be covered by the range of accepted changes in the LTS Plan…

  2. jasnell commented on Apr 28, 2017

    @jasnell
    MemberAuthor

    They can on a case by case basis during the Active LTS phase.

  3. TimothyGu commented on Apr 28, 2017

    @TimothyGu
    Member

    Okay, rules notwithstanding personally I think it is a great addition. As a maintainer of node-fetch, the availability of a high-performance standard-compliant URL parser in all supported Node.js versions would be a boon for tricky bugs like node-fetch/node-fetch#245.

  4. MylesBorins commented on Apr 28, 2017

    @MylesBorins
    Contributor
  5. joyeecheung commented on Apr 28, 2017

    @joyeecheung
    Member

    Can't see any harm in the idea...so +1

  6. gibfahn commented on Apr 28, 2017

    @gibfahn
    Member

    +1, seems reasonable once it's graduated.

  7. targos commented on Apr 28, 2017

    @targos
    Member

    SGTM

  8. watilde commented on Apr 28, 2017

    @watilde
    Member

    Sounds good to me as well.

  9. sam-github commented on Apr 28, 2017

    @sam-github
    Contributor

    +1 once not experimental

  10. kumar303 commented on Sep 14, 2017

    @kumar303

    It looks like it's graduated from experimental status now, right? nodejs/node#12710

  11. jasnell commented on Sep 14, 2017

    @jasnell
    MemberAuthor

    Yes. It's no longer experimental

  12. gibfahn commented on Sep 16, 2017

    @gibfahn
    Member

    This has plenty of +1s, so I guess it's just waiting for someone to raise a backport PR.

  13. TimothyGu commented on Nov 28, 2017

    @TimothyGu
    Member

    Backport PR: nodejs/node#17365

  14. mhdawson commented on Nov 28, 2017

    @mhdawson
    Member

    +1 from me as well.

  15. MylesBorins commented on Feb 10, 2018

    @MylesBorins
    Contributor

    Coming out in 6.13.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions