Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: airbnb/javascript
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: nanogiants/javascript
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: develop
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 13 commits
  • 3 files changed
  • 2 contributors

Commits on Jan 18, 2017

  1. Change max_line_length to 120 

     Add .eslintrc file
 Update README.md
    @ph1p
    ph1p committed Jan 18, 2017
    Configuration menu
    Copy the full SHA
    cef39c7 View commit details
    Browse the repository at this point in the history

  2. Change max_line_length to 120 

    Add .eslintrc file
Update README.md
    @ph1p
    ph1p committed Jan 18, 2017
    Configuration menu
    Copy the full SHA
    1ba92a4 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2017

  1. Update README.md

    @ph1p
    ph1p committed Jan 19, 2017
    Configuration menu
    Copy the full SHA
    5a2f615 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' of http://appcom-stash/scm/apcon/appcom-conven… 

    …tions-javascript into develop

# Conflicts:
#	README.md
    @ph1p
    ph1p committed Jan 19, 2017
    Configuration menu
    Copy the full SHA
    3ffa09b View commit details
    Browse the repository at this point in the history

  3. Overload max-len eslint rule and set max length to 120

    @stneidig
    stneidig committed Jan 19, 2017
    Configuration menu
    Copy the full SHA
    69652fa View commit details
    Browse the repository at this point in the history

  4. Declare alphabetical attribute sort order in object definitions

    @stneidig
    stneidig committed Jan 19, 2017
    Configuration menu
    Copy the full SHA
    6b8cc43 View commit details
    Browse the repository at this point in the history

  5. Add prefer-spread lint rule to section 3.8

    @stneidig
    stneidig committed Jan 19, 2017
    Configuration menu
    Copy the full SHA
    3aa5367 View commit details
    Browse the repository at this point in the history

  6. Add prefer-spread lint rule to section 4.3

    @stneidig
    stneidig committed Jan 19, 2017
    Configuration menu
    Copy the full SHA
    d5bd13b View commit details
    Browse the repository at this point in the history

  7. Declare a maximum line length of 120 instead of 100

    @stneidig
    stneidig committed Jan 19, 2017
    Configuration menu
    Copy the full SHA
    5fcfc97 View commit details
    Browse the repository at this point in the history

  8. Add es lint no-eval rule to section 6.4

    @stneidig
    stneidig committed Jan 19, 2017
    Configuration menu
    Copy the full SHA
    b88c6c3 View commit details
    Browse the repository at this point in the history

  9. Various changes to code style to make it applicaple to us

    @stneidig
    stneidig committed Jan 19, 2017
    Configuration menu
    Copy the full SHA
    25fb404 View commit details
    Browse the repository at this point in the history

  10. Add proper copyright note and add missing amendments

    @stneidig
    stneidig committed Jan 19, 2017
    Configuration menu
    Copy the full SHA
    e52a3a3 View commit details
    Browse the repository at this point in the history

  11. Remove gitter badge, since we are not Airbnb

    @stneidig
    stneidig committed Jan 19, 2017
    Configuration menu
    Copy the full SHA
    a90cda8 View commit details
    Browse the repository at this point in the history
Loading