Repository navigation
Split the client SDK into a standalone mcp-client package #3583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
e49a483
7db42b6
eed6aaa
b16ce08
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -48,6 +48,31 @@ jobs: | |
| uv run --isolated --no-project --with ./src/mcp-types python -c \ | ||
| "import mcp_types, mcp_types.jsonrpc, mcp_types.methods, mcp_types.version, mcp_types._v2025_11_25, mcp_types._v2026_07_28" | ||
|
|
||
| packages: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | ||
| with: | ||
| persist-credentials: false | ||
| - uses: astral-sh/setup-uv@20cfd1bf945f4377ade1205e4dbc17946fc9a30d # v10.0.1 | ||
| with: | ||
| version: 0.9.5 | ||
| - name: Build all distributions | ||
| run: | | ||
| uv build --package mcp-types | ||
| uv build --package mcp-client | ||
| uv build --package mcp | ||
| - name: Exercise the client wheel and sdist without the server SDK | ||
| run: | | ||
| for package in dist/mcp_client-*.whl dist/mcp_client-*.tar.gz; do | ||
| uv run --isolated --no-project --find-links dist --with "$package" \ | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P2: The package checks run under only the runner's implicit Python version, so they do not validate the built wheel and sdist at the supported 3.10 and 3.14 endpoints. Add a Python matrix or explicit Prompt for AI agents |
||
| python scripts/check_client_package.py | ||
| done | ||
| - name: Import the full SDK with the client package first | ||
| run: | | ||
| uv run --isolated --no-project --find-links dist --with dist/mcp-*.whl python -c \ | ||
| 'import mcp_client, mcp; from typing import get_type_hints; assert mcp.Client is mcp_client.Client; get_type_hints(mcp.Client)' | ||
|
|
||
| test: | ||
| name: test (${{ matrix.python-version }}, ${{ matrix.dep-resolution.name }}, ${{ matrix.os }}) | ||
| runs-on: ${{ matrix.os }} | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -133,7 +133,7 @@ Two things about it matter more than what it does. | |
| The whole request fails, as a top-level protocol error: | ||
|
|
||
| ```text | ||
| mcp.shared.exceptions.MCPError: Cannot send 'elicitation/create': this transport context has no back-channel for server-initiated requests. | ||
| mcp_client.shared.exceptions.MCPError: Cannot send 'elicitation/create': this transport context has no back-channel for server-initiated requests. | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P2: Regenerate and commit the translated (Based on your team's feedback about keeping translated docs aligned with the English source.) . Prompt for AI agents |
||
| ``` | ||
|
|
||
| `Resolve` did not save you. On a `2025-11-25` connection it *has* to send `elicitation/create`, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we have this job?