Skip to content

Commit bff0417

Browse files
vstinnermiss-islington
vstinner
authored and
miss-islington
committed
bpo-34092, test_logging: increase SMTPHandlerTest timeout (pythonGH-8245)
Change test_logging.SMTPHandlerTest timeout from 8 seconds to 1 minute. The test failed randomly on the slow x86 Gentoo Refleaks 3.7 buildbot. (cherry picked from commit 31b50b8) Co-authored-by: Victor Stinner <vstinner@redhat.com>
1 parent 6b1b6e4 commit bff0417

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

‎Lib/test/test_logging.py‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -971,7 +971,8 @@ class TestUnixDatagramServer(TestUDPServer):
971971
# - end of server_helper section
972972

973973
class SMTPHandlerTest(BaseTest):
974-
TIMEOUT = 8.0
974+
# bpo-14314, bpo-19665, bpo-34092: don't wait forever, timeout of 1 minute
975+
TIMEOUT = 60.0
975976

976977
def test_basic(self):
977978
sockmap = {}
@@ -986,7 +987,7 @@ def test_basic(self):
986987
r = logging.makeLogRecord({'msg': 'Hello \u2713'})
987988
self.handled = threading.Event()
988989
h.handle(r)
989-
self.handled.wait(self.TIMEOUT) # 14314: don't wait forever
990+
self.handled.wait(self.TIMEOUT)
990991
server.stop()
991992
self.assertTrue(self.handled.is_set())
992993
self.assertEqual(len(self.messages), 1)

0 commit comments

Comments
 (0)